Re: imonlcd: spinning disc and progess bars

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Eric,

Thanks for your fast reply. I will try out your patch as soon as
possible and give you feedback. Tommorow I am going on vacation and will
not return home before Tuesday.

Regarding the 1 second delay: I think you misunderstood me. In the perl
script I attached I set the spinning disc followed by a "sleep 1",
followed by a progress bar update, followed by a "sleep 1" followed by
spanning disc setting. In that case the progress bar update stops the
disc from spinning, and after one second it starts spinning again
because I set it on again.

In my XBMC the display is updated 4 times a second, the disc stops for a
quarter second in that case.

Karsten

On 21.04.2011 02:03, Eric Pooch wrote:
> I needed to make another small change.  try this patch instead:
> 
> 
> patch on 0.5.4
>  again, it complies but I did not test it.
> 
> --Eric
> 
> On Apr 20, 2011, at 4:16 PM, Eric Pooch wrote:
> 
>> Try this patch on 0.5.4:<imonlcd_output_bars_spin.patch>
>>
>> It will update the icons (including the spinning cd) even when the
>> client output request is to only update the bars.  However, it retains
>> the original 0.5.4 bug fix.
>> It also cleans up some old unnecessary code in the output function.
>>
>>
>> it compiles, but I did not test it.
>>
>> --Eric
>>
>> On Apr 20, 2011, at 3:25 PM, Eric Pooch wrote:
>>
>>> The change between 0.5.3 and 0.5.4 fixed a serious bug where the
>>> driver would continuously send commands to update the display icons,
>>> even when there were no changes needed.  As a result of this bug, I
>>> experienced display instability.  Your patch re-introduces the bug. 
>>> I have not noticed the 1 second delay you mention. However, I can see
>>> in the code where it only updates the bars when there is an output
>>> command made by the client.  As a result, it skips an opportunity to
>>> update the spinning disc.  This change should be relatively simple to
>>> implement.  I will make a patch.
>>> In the mean time, you might want to check what is going on with your
>>> configuration that is causing 1 second delay to update the icons. 
>>> what kind of computer are you using?  Have you made configuration
>>> changes to slow down LCDproc?
>>>
>>> --Eric
>>>
>>> On Apr 20, 2011, at 2:29 PM, Karsten A. M. Günther wrote:
>>>
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA1
>>>>
>>>> Hello lcdproc'ers,
>>>>
>>>> I would like to ask you a question regarding lcdproc 0.5.4 and the
>>>> imonlcd driver. I am working on a patch for XBMC media center for full
>>>> icon support in combination with Soundgraph's IMON LCD display and
>>>> lcdproc (http://trac.xbmc.org/ticket/8981). In fact, it is working
>>>> quite
>>>> fine, but since lcdproc 0.5.4 there is an issue regarding the spinning
>>>> disc animation. Everytime, the progress bars are updated, the animation
>>>> stops for a short moment until the icons are updated again. I wrote the
>>>> attached perl script to verify this. This script executed with lcdproc
>>>> 0.5.3 shows the spinning disc and a second later all progress bars and
>>>> lines. The disc keeps spinning as expected. With lcdproc 0.5.4 the disc
>>>> starts spinning, after a seconds it stops and the progress bars come up
>>>> and after another second it starts spinning again.
>>>>
>>>> For my needs I reverted some changes in imonlcd.c, see attached
>>>> patch file.
>>>>
>>>> My question: am I doing or understanding something wrong or is this
>>>> just
>>>> a bug in the code cleanup and rework you did in imonlcd.c between 0.5.3
>>>> and 0.5.4?
>>>>
>>>> Best regards,
>>>> Karsten Guenther
>>>>
>>>> -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1.4.10 (GNU/Linux)
>>>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>>>>
>>>> iQEcBAEBAgAGBQJNr1A1AAoJEGeYm4AaNYHY1i4IAIDnk2KjUrIrq0363R3Kmez0
>>>> nIJKlGbZNepvISGK1ATpnPd14HCDfbDo0UJi1PPc4PMZsDJ0XkJoOd4sVTrKLyxr
>>>> unFQGBOxJFUBFXUUTvjjQG9mTZsrdAZagHmskt9C0oPBGZGJeCeu4JQUiegr3OvK
>>>> zBAgQi0ms3Fx3kcSjQQmMZ9/GjXOSMGl4mJ0gB9g+Us5GWg3eC3w8+mq0FeXWdYU
>>>> YFGD8a45kHxUDRM3PLv3vbWXB81D3hwyYaTzpEwSoGjmxJqvCLXIxtuwr1nHLfFw
>>>> fEsprXN75kvOc9Jt9Z6odx+XWzZEGrlHRI2wF593BR3vpb2lWoyppP5agFPWeX8=
>>>> =hzqM
>>>> -----END PGP
>>>> SIGNATURE-----<imon_disc_and_progress.pl><imonlcd.c.diff>_______________________________________________
>>>>
>>>> LCDproc mailing list
>>>> [email protected]
>>>> http://lists.omnipotent.net/mailman/listinfo/lcdproc
>>>
>>
>> _______________________________________________
>> LCDproc mailing list
>> [email protected]
>> http://lists.omnipotent.net/mailman/listinfo/lcdproc
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNsHvFAAoJEGeYm4AaNYHYTaEH/2T9TrHynneQHjlhO+ijFijT
YSmzagVgCzUvKyEww8LCCdTAZOMyXF3+79QTez0k1YwSg0Fnptgq/QTSiytZmcHz
8APge/8mjFUM9+lzvUEys2dSlkRxdlQta/RhXWEd5G9GTjfQxjxTik/pI9Qkac0w
pbWirTk00js+el4vWlpF2hVlgbTTGIJKkukpIHGOOpjX1tVy10I6u6em4/c+FnmE
c8AJ6GOpTP+6VpdiAa5OPFEpsWK4UejAUjHGKydchtS6rzOOGDnFJzKmDj94hMVq
bv30nT9hnzvpqbqZ4tOWagamiIDmwBZGcy3ps8KJhapkshN8nubJ9iM4Es/rIv8=
=Oa67
-----END PGP SIGNATURE-----