Re: imonlcd: spinning disc and progess bars

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Eric,

A fresh build of lcdproc 0.5.4 with your latest patch applied works
flawlessly with my test script and also with my XBMC build. The disc
animation keeps spinning fluently even during progress bar updates.

Thanks a lot for your fast solution, you made my day!

Regards,
Karsten

On 23.04.2011 06:13, Eric Pooch wrote:
> I understand now.  Here is a final patch that should fix the problem you
> are seeing.
> Let me know how it works and I will test and submit it.
> 
> --Eric
> On Apr 21, 2011, at 11:47 AM, Karsten A. M. Günther wrote:
> 
> Hello Eric,
> 
> Thanks for your fast reply. I will try out your patch as soon as
> possible and give you feedback. Tommorow I am going on vacation and will
> not return home before Tuesday.
> 
> Regarding the 1 second delay: I think you misunderstood me. In the perl
> script I attached I set the spinning disc followed by a "sleep 1",
> followed by a progress bar update, followed by a "sleep 1" followed by
> spanning disc setting. In that case the progress bar update stops the
> disc from spinning, and after one second it starts spinning again
> because I set it on again.
> 
> In my XBMC the display is updated 4 times a second, the disc stops for a
> quarter second in that case.
> 
> Karsten
> 
> On 21.04.2011 02:03, Eric Pooch wrote:
>>>> I needed to make another small change.  try this patch instead:
>>>>
>>>>
>>>> patch on 0.5.4
>>>>  again, it complies but I did not test it.
>>>>
>>>> --Eric
>>>>
>>>> On Apr 20, 2011, at 4:16 PM, Eric Pooch wrote:
>>>>
>>>>> Try this patch on 0.5.4:<imonlcd_output_bars_spin.patch>
>>>>>
>>>>> It will update the icons (including the spinning cd) even when the
>>>>> client output request is to only update the bars.  However, it retains
>>>>> the original 0.5.4 bug fix.
>>>>> It also cleans up some old unnecessary code in the output function.
>>>>>
>>>>>
>>>>> it compiles, but I did not test it.
>>>>>
>>>>> --Eric
>>>>>
>>>>> On Apr 20, 2011, at 3:25 PM, Eric Pooch wrote:
>>>>>
>>>>>> The change between 0.5.3 and 0.5.4 fixed a serious bug where the
>>>>>> driver would continuously send commands to update the display icons,
>>>>>> even when there were no changes needed.  As a result of this bug, I
>>>>>> experienced display instability.  Your patch re-introduces the bug.
>>>>>> I have not noticed the 1 second delay you mention. However, I can see
>>>>>> in the code where it only updates the bars when there is an output
>>>>>> command made by the client.  As a result, it skips an opportunity to
>>>>>> update the spinning disc.  This change should be relatively simple to
>>>>>> implement.  I will make a patch.
>>>>>> In the mean time, you might want to check what is going on with your
>>>>>> configuration that is causing 1 second delay to update the icons.
>>>>>> what kind of computer are you using?  Have you made configuration
>>>>>> changes to slow down LCDproc?
>>>>>>
>>>>>> --Eric
>>>>>>
>>>>>> On Apr 20, 2011, at 2:29 PM, Karsten A. M. Günther wrote:
>>>>>>
>>>>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>>>>> Hash: SHA1
>>>>>>>
>>>>>>> Hello lcdproc'ers,
>>>>>>>
>>>>>>> I would like to ask you a question regarding lcdproc 0.5.4 and the
>>>>>>> imonlcd driver. I am working on a patch for XBMC media center for
>>>>>>> full
>>>>>>> icon support in combination with Soundgraph's IMON LCD display and
>>>>>>> lcdproc (http://trac.xbmc.org/ticket/8981). In fact, it is working
>>>>>>> quite
>>>>>>> fine, but since lcdproc 0.5.4 there is an issue regarding the
>>>>>>> spinning
>>>>>>> disc animation. Everytime, the progress bars are updated, the
>>>>>>> animation
>>>>>>> stops for a short moment until the icons are updated again. I
>>>>>>> wrote the
>>>>>>> attached perl script to verify this. This script executed with
>>>>>>> lcdproc
>>>>>>> 0.5.3 shows the spinning disc and a second later all progress bars
>>>>>>> and
>>>>>>> lines. The disc keeps spinning as expected. With lcdproc 0.5.4 the
>>>>>>> disc
>>>>>>> starts spinning, after a seconds it stops and the progress bars
>>>>>>> come up
>>>>>>> and after another second it starts spinning again.
>>>>>>>
>>>>>>> For my needs I reverted some changes in imonlcd.c, see attached
>>>>>>> patch file.
>>>>>>>
>>>>>>> My question: am I doing or understanding something wrong or is this
>>>>>>> just
>>>>>>> a bug in the code cleanup and rework you did in imonlcd.c between
>>>>>>> 0.5.3
>>>>>>> and 0.5.4?
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Karsten Guenther
>>>>>>>
>>>>>>> 

_______________________________________________
LCDproc mailing list
[email protected]
http://lists.omnipotent.net/mailman/listinfo/lcdproc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNuAIcAAoJEGeYm4AaNYHYo+AH+wUIX+CrXnLT+ZtGDjRNBvsc
8j4tdCPMAuCla1BqnAg+XXA+MuS85xEsyLcnXSqpQvtgrsevr7upP2ECHMIa1bxZ
oZ/BzV8QRDZwkmwJR57mh/EvPWTktlu/P9iUkrgpi3ZMFi9f1frrBMptlMT3cixR
4tcI3Vt5G6O2vChAaWUUnoedF95Q3vzc2tAg3mnBb7Yt0vdmrYf41+XK2ErL049U
IiiG+amvG2vFgAbh4Y5jFhFK5M3Ln3+uftKe9Kw9k8rTT7eQPhCuMcLuoVtaKzMP
eEtRo5sGfzt2UcCWU1hswtyHKamsvvBbnjDZz0SA6sT2LZoqiw04WFGVlYmgscU=
=GzKs
-----END PGP SIGNATURE-----