Re: Patch that allows remote control global backlight

On 15.09.2011 19:18, Ch Fetzer wrote:
> Hello everyone!
>
> I created a patch that allows to control the global server backlight option
> using the client protocol:
>
> server_backlight {on|off|open|toggle}
>
> When reading throught the archives, I found that a remote control interface
> for lcdproc settings was discussed a few years ago.
>
> In my opinion it would be realy cool to have it
> I use lcdproc on my media server that is always running.
> With that patch i'm able to switch the lcd backlight on when switching on the
> tv.
>
> The patch is not perfect as the options menu is not updated.
> (I didn't find a way without making the option menu globally available. Any
> tipps?)
>
> It would also be cool to add other commands like
> - screen_goto
> - screen_next
> - screen_prev
>
> What do you think. Any chances that it'll make it to the trunk? Maybe with an
> compiler option or flag in the server config to enable / disable it.
>
> Thanks,
> Christian
>

Hello Christian,

I will not commit this.

Reasons:

   1. While modifying the server's backlight setting seems as easy as in
      your patch, there may have been reason why it is _not_ allowed for
      clients to do so but instead handle backlight per client. I
      understand that this is inconvenient for people who want to turn
      it off during the night using a script.
   2. It does modify the server's internal value without taking the
      setting in LCDd.conf into account. For example, if the backlight
      is forced to 'off' by the admin your patch allows client to
      circumvent this setting.

Feel free to add it to http://sourceforge.net/apps/ideatorrent/lcdproc/
and have others vote on it. If many people want this, we may look for a
better solution.

Regards,
Markus

_______________________________________________
LCDproc mailing list
[email protected]
http://lists.omnipotent.net/mailman/listinfo/lcdproc