Re: imonlcd 0x0 command turning off progress bar

		Hi!

On 16.10.2011 15:36, Markus Dolze wrote:

>> Now imonlcd driver assuming that 0x0 clear icons only. The simple
>> solution is to modify driver that on 0x0 command it should clear the
>> bar state too.
>
> Currently there are two options:
>
>     1. '-1' will turn all icons _and_ bars on. '0x0' will turn all icons
>        _and_ bars off.
>     2. '-1' will _not_ turn on the bars and '0x0' will _not_ turn them off.
>
> 1.) This Is current behavior and has not been changed since 0.5.4. The
> bug is that bars do not turn on again after '0x0' if the same bar state
> is sent again. This will be easy to fix.
>
> 2.) This is a change in the meaning of '-1' and '0x0' and will require
> applications to be updated to additionally set and clear the bars.
>
> I suggest to stay with 1.) and to just reset the last_output_bar_state
> upon '-1' or '0x0'.

Yes, I think option 1 is more preferable.

-- 
Best regards, Yura.