Re: imonlcd 0x0 command turning off progress bar
Eric Pooch <[email protected]>
| Newsgroups | gmane.comp.sysutils.lcdproc |
|---|---|
| Message-ID | <[email protected]> |
So, six bits can't hold the direction AND the 32 pixels for each line, so there is no way with the existing protocol to have the last pixel light up. You only get 31 pixels plus the direction bit. This seems strange because there are 4 extra bits that can be used to hold this info (bits 24-27). I am not going to change anything to fix this for now. On Oct 17, 2011, at 12:16 PM, Eric Pooch wrote: > Here is the patch to fix the issues raise by Yura. > <imonlcd_output_allon.patch> > I noticed a few things: > 1) The IMON_OUTPUT_PBARS_MASK captures an output value of -1 > because of the binary value of negative numbers. I don't think > this was expected in the previous version and resulted in not all > of the icons coming on. > 2) an output value of -1 includes the CD spinning bit, so the > driver would continue to send commands to set the icons even if > nothing was changing. I accounted for that in the cache check: > if (state == p->last_output_state && !(state != -1 && (state & > IMON_OUTPUT_CD_MASK))) > > 3)The left-most bar on the top and bottom does not light up due to > a pre-existing bug . I will have a patch for that shortly. > > --Eric > > On Oct 16, 2011, at 10:06 AM, Yura Scheglyuk wrote: > >> Hi! >> >> On 16.10.2011 15:36, Markus Dolze wrote: >> >>>> Now imonlcd driver assuming that 0x0 clear icons only. The simple >>>> solution is to modify driver that on 0x0 command it should clear >>>> the >>>> bar state too. >>> >>> Currently there are two options: >>> >>> 1. '-1' will turn all icons _and_ bars on. '0x0' will turn >>> all icons >>> _and_ bars off. >>> 2. '-1' will _not_ turn on the bars and '0x0' will _not_ turn >>> them off. >>> >>> 1.) This Is current behavior and has not been changed since >>> 0.5.4. The >>> bug is that bars do not turn on again after '0x0' if the same bar >>> state >>> is sent again. This will be easy to fix. >>> >>> 2.) This is a change in the meaning of '-1' and '0x0' and will >>> require >>> applications to be updated to additionally set and clear the bars. >>> >>> I suggest to stay with 1.) and to just reset the >>> last_output_bar_state >>> upon '-1' or '0x0'. >> >> Yes, I think option 1 is more preferable. >> >> -- >> Best regards, Yura. >> _______________________________________________ >> LCDproc mailing list >> [email protected] >> http://lists.omnipotent.net/mailman/listinfo/lcdproc > > _______________________________________________ > LCDproc mailing list > [email protected] > http://lists.omnipotent.net/mailman/listinfo/lcdproc