Re: Fix build on OpenBSD

Hi Markus,

Thanks for getting back to me.

On Thu, Nov 17, 2011 at 07:22:16AM +0100, Markus Dolze wrote:
> > 1. Using <machine/apmvar.h> seems to be the preferred way. In old
> > OpenBSD 'machine' is just a symlink to 'i386' and all man pages instruct
> > to use machine/apmvar.h.
> >
> > Will commit this.

Thanks.

> > 2. kvm_getprocs() with 5 parameters seems to be new on OpenBSD 5. Thus
> > the patch will likely break any older version. There must be a check on
> > either OpenBSD version or on the parameter set kvm_getprocs() accepts
> > (likely in configure script).
> >
> > I'm currently not deep enough into OpenBSD to do this. Somebody else?

If you want to offer backward compatibility, then in my opinion, a
configure check testing if a {4 param, 5 param} call to kvm_getprocs()
is possible is better than testing for operating system versions.

But that is just my thoughts.

-- 
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk