Re: Patch adds support for the Adafruit PiPlate

Hi,

committed (with documentation). Thank you.

You should test the driver, as I have made some changes to it:
- Rename the whole thing to piplate (instead of i2c-piplate; however,
the internal function names have not been changed).
- Optimize senddate() / backlight() to reduce I2C traffic.
- Consolidate write_4_nibble() into senddata().
- Change the default I2C device for Pi Rev 2.
- Add FreeBSD support (not that anyone is running this on a Pi, but to
allow me to compile the driver on my development machine).

Regards,
Markus


On 25.03.2013 20:58, Jonathan Brogdon wrote:
> OK.  Thanks, Markus.  Let me know if there is anything else I can provide.
> 
> Jon
> 
> On Mon, Mar 25, 2013 at 1:26 PM, Markus Dolze <[email protected]
> <mailto:[email protected]>> wrote:
> 
>     Hi Jon,
> 
>     thank you for your submission. You don't need to resubmit patches
>     (unless it doesn't show up in the mailing list archive). They are
>     reviewed if I have some spare time.
> 
>     Regards,
>     Markus
> 
>     On 25.03.2013 14 <tel:25.03.2013%2014>:18, Jonathan Brogdon wrote:
>     > Never saw a response on the corrected patch for the Adafruit PiPlate.
>     >  Resubmitting.
>     >
>     > Jon
>     >
>     > ---------- Forwarded message ----------
>     > From: *Jonathan Brogdon* <[email protected]
>     <mailto:[email protected]>
>     > <mailto:[email protected] <mailto:[email protected]>>>
>     > Date: Mon, Feb 18, 2013 at 9:34 AM
>     > Subject: [Lcdproc] Patch adds support for the Adafruit PiPlate
>     > To: [email protected]
>     <mailto:[email protected]>
>     <mailto:[email protected]
>     <mailto:[email protected]>>
>     >
>     >
>     > You are correct regarding the blue backlight pin.  I've fixed the
>     > code, and attached a new patch.
>     >
>     > Jon
>     >
>     >
>     > On Tue, Feb 12, 2013 at 1:29 AM, Markus Dolze
>     <[email protected] <mailto:[email protected]>
>     > <mailto:[email protected] <mailto:[email protected]>>> wrote:
>     >
>     >     On 11.02.2013 22:32, Jonathan Brogdon wrote:
>     >     > Never saw this on the mailing list, or a response.  Re-sending.
>     >     >
>     >     > Jon
>     >     >
>     >     > ---------- Forwarded message ----------
>     >     > From: *Jonathan Brogdon* <[email protected]
>     <mailto:[email protected]>
>     >     <mailto:[email protected] <mailto:[email protected]>>
>     >     > <mailto:[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>>>>
>     >     > Date: Sat, Feb 9, 2013 at 1:26 AM
>     >     > Subject: [PATCH] Add support for the Adafruit PiPlate
>     >     > To: [email protected]
>     <mailto:[email protected]>
>     >     <mailto:[email protected]
>     <mailto:[email protected]>>
>     >     <mailto:[email protected]
>     <mailto:[email protected]>
>     >     <mailto:[email protected]
>     <mailto:[email protected]>>>
>     >     >
>     >     >
>     >     > For your consideration, I have attached a v0.5.6 patch which
>     adds a
>     >     > driver for the Adafruit PiPlate
>     (http://adafruit.com/products/1109).
>     >     >  The PiPlate includes a HD44780 LCD and 5 button keys which is
>     >     > accessed via a MCP23017 I2C IO expander.
>     >     >
>     >     > The driver was adapted from the HD44780-i2c driver, which
>     uses the
>     >     > PCF8574 I2C IO expander.
>     >     >
>     >     > Jon Brogdon
>     >     >
>     >
>     >     Hi,
>     >
>     >     please read [1]. Thank you.
>     >
>     >     [1]
>     http://lcdproc.sourceforge.net/docs/current-dev.html#code-style
>     >
>     >     According to the schematic from [1], the pin for blue
>     backlight is on
>     >     GPB0, not on GPA8 (which does not exist anyway).
>     >
>     >     Is the schematic wrong or did I miss something?
>     >
>     >     [2]
>     >    
>     http://learn.adafruit.com/system/assets/assets/000/003/861/original/pilcdplate.png?1360171818
>     >
>     >     Regards,
>     >     Markus
>     >
>     >     _______________________________________________
>     >     LCDproc mailing list
>     >     [email protected]
>     <mailto:[email protected]>
>     <mailto:[email protected]
>     <mailto:[email protected]>>
>     >     http://lists.omnipotent.net/mailman/listinfo/lcdproc
>     >
>     >
>     >
>     >
>     >
>     >
>     > _______________________________________________
>     > LCDproc mailing list
>     > [email protected] <mailto:[email protected]>
>     > http://lists.omnipotent.net/mailman/listinfo/lcdproc
> 
>     _______________________________________________
>     LCDproc mailing list
>     [email protected] <mailto:[email protected]>
>     http://lists.omnipotent.net/mailman/listinfo/lcdproc
> 
>