Re: picolcdgfx driver

Hi,

committed, thank you.

Regards,
Markus


On 08.05.2013 03:17, Scott Meharg wrote:
> See replies below.
> 
> Attached is the updated driver.
> 
> Thanks,
> Scott
> 
> 
> On Sun, May 5, 2013 at 3:07 PM, Markus Dolze <[email protected]
> <mailto:[email protected]>> wrote:
> 
>     On 30.01.2013 01:59, Scott Meharg wrote:
>>     Attached is the patch and file for Mini-box.com's PicoLCDGraphics LCD.
>>
>>     It uses glcd driver with connect type picolcdgfx.
>>
> 
>     Hi,
> 
>     I had a look at this patch this weekend. There are a few things I
>     ask you to test:
> 
>      1. With recent LCDproc CVS version 'paged' memory layouts are
>         directly supported. This means there is no conversion necessary
>         from 'linear' to 'paged' memory layout. I had to initialize the
>         backingstore with 0xFF so the first call of _blit would clear
>         the ROM graphic from the screen.
>      2. If the backlight is just switchable (on/off) or if it is
>         adjustable (from 0 to max). From reading the lcd4linux I believe
>         the latter being true. In this case the driver should be updated
>         to make use of (on_brightness / off_brightness).  The lcd4linux
>         driver did not show a an adjustable backlight.  But I tested and
>         it does support.  Driver has been update to make use of
>         (on_brightness / off_brightness).
>      3. The way to calculate the contrast setting looks a little weird.
>         See my comment in the updated driver.  Weird indeed.  What was I
>         thinking.
> 
>     Attached you find an updated version of the driver. You will need
>     LCDproc sources as of today for the patch to apply cleanly.
> 
>     Regards,
>     Markus
> 
>