Re: PCP Updates: RHBZ 1348349: pmchart(1): Table of metrics, instances and values

----- Original Message -----
> On 10/07/2016 03:06 AM, Nathan Scott wrote:
> > Hi Dave,
> >
> > ----- Original Message -----
> >> This is my first Qt creation using the qt designer tool. A review of all
> >> aspects is definitely warranted.
> >>
> >
> > - should be using a QDialog here rather than a new QMainWindow I think
> > (allows dialog-OK button, which we also need here) - we don't need the
> > menu bar, status bar, etc of a QMainWindow in a QDialog;
> I integrated this change however, once nice thing about it being a Main
> Window was that you could move it aside and it would stay open and
> update itself as you clicked around the chart. It also got its own
> window controls, so you didn't need the OK button. The QDialog

Its still good UI-design form to have dialogs that have buttons (as well
as window-manager buttons to dismiss 'em) - there's a document about this
somewhere on the net, but I've not been able to find it so far; will keep
looking.

> implementation seems to open this window "on top" of the chart window
> (sorry, there's probably a better technical term) and you can't move it
> aside or click on the chart again until you close it. I can't seem to
> find a setting to make the dialog independent of the chart window. Do
> you know if there is one?

Yep, this is the concept of "modal" vs "non-modal" windows - grep on
Qt::WindowModal across the .ui files.  We have a mix in pmchart, some
are modal some are not - I think you're right & we want the non-modal
variety here.

> > - (re-)sizing of dialogs I always find tricky, and when I resize this
> > one, everything stays "static" - ideally the widgets would all resize
> > with the dialog window.  Have a look at the way saveviewdialog.ui does
> > this, e.g. when clicking+dragging on the window-manager-window see how
> > everything reshapes.
> In order to resize, you need a main layout. I added that and restored
> thge QTableWidget setting to stretch the chart as I described before
> (right-most column and bottom-most row get stretched).
> 
> Attached is the updated .ui file. Give it a try and let me know what you
> think.

Will do, ran outta time today though.

cheers.

--
Nathan

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14503): https://groups.io/g/pcp/message/14503
View All Messages In Topic (4): https://groups.io/g/pcp/topic/2881991
Mute This Topic: https://groups.io/mt/2881991?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-