Re: PCP Updates: RHBZ 1348349: pmchart(1): Table of metrics, instances and values

I've pushed some more changes which address most of the comments below.

The one remaining item is to only pop-up one window when there is more 
than one view opened. I see that there is one window per chart opened, 
even when there are multiple tabs. That is, one window gets opened for 
each chart across all tabs. I'm not really sure how to prevent this. 
Each Chart object receives the "selected" signal and I can't see a way 
to tell which chart was actually clicked on. If anyone can point me in 
the right direction, it would be appreciated.

FWIW, now the popped-up windows are no longer modal. Each can be moved 
aside and will be updated with each new click on the chart. It's not 
exactly what Nathan wanted, but not completely unusable anymore.

Changes committed to git://git.pcp.io/brolley/pcp qt

Dave Brolley (2):
       RHBZ 1348349: pmchart(1): Table of metrics, instances and values.
       pmchart(): Delete some unused code.

  src/pmchart/chart.cpp         |   32 --------
  src/pmchart/metricdetails.cpp |   16 ----
  src/pmchart/metricdetails.h   |    7 -
  src/pmchart/metricdetails.ui  |  161 
++++++++++++++++++++++++++++++------------
  4 files changed, 120 insertions(+), 96 deletions(-)

Details ...

commit de64b041db6e4110393829754c4948eb44ecb50a
Author: Dave Brolley <[email protected]>
Date:   Mon Oct 17 14:46:09 2016 -0400

     pmchart(): Delete some unused code.

commit c22387e2b14b6a85dd29f7db4ea7d982e60ec10e
Author: Dave Brolley <[email protected]>
Date:   Mon Oct 17 11:54:25 2016 -0400

     RHBZ 1348349: pmchart(1): Table of metrics, instances and values.

     Based on a patch from Nathan Scott <[email protected]>.

     Use QDialog for the window. Make it non-modal and add an "OK"
     button to dismiss the window.


On 10/13/2016 04:51 AM, Nathan Scott wrote:
>
> ----- Original Message -----
>> On 10/07/2016 03:06 AM, Nathan Scott wrote:
>>> Hi Dave,
>>>
>>> ----- Original Message -----
>>>> This is my first Qt creation using the qt designer tool. A review of all
>>>> aspects is definitely warranted.
>>>>
>>> - should be using a QDialog here rather than a new QMainWindow I think
>>> (allows dialog-OK button, which we also need here) - we don't need the
>>> menu bar, status bar, etc of a QMainWindow in a QDialog;
>> I integrated this change however, once nice thing about it being a Main
>> Window was that you could move it aside and it would stay open and
>> update itself as you clicked around the chart. It also got its own
>> window controls, so you didn't need the OK button. The QDialog
> Its still good UI-design form to have dialogs that have buttons (as well
> as window-manager buttons to dismiss 'em) - there's a document about this
> somewhere on the net, but I've not been able to find it so far; will keep
> looking.
>
>> implementation seems to open this window "on top" of the chart window
>> (sorry, there's probably a better technical term) and you can't move it
>> aside or click on the chart again until you close it. I can't seem to
>> find a setting to make the dialog independent of the chart window. Do
>> you know if there is one?
> Yep, this is the concept of "modal" vs "non-modal" windows - grep on
> Qt::WindowModal across the .ui files.  We have a mix in pmchart, some
> are modal some are not - I think you're right & we want the non-modal
> variety here.
>
>>> - (re-)sizing of dialogs I always find tricky, and when I resize this
>>> one, everything stays "static" - ideally the widgets would all resize
>>> with the dialog window.  Have a look at the way saveviewdialog.ui does
>>> this, e.g. when clicking+dragging on the window-manager-window see how
>>> everything reshapes.
>> In order to resize, you need a main layout. I added that and restored
>> thge QTableWidget setting to stretch the chart as I described before
>> (right-most column and bottom-most row get stretched).
>>
>> Attached is the updated .ui file. Give it a try and let me know what you
>> think.
> Will do, ran outta time today though.
>
> cheers.
>
> --
> Nathan
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14526): https://groups.io/g/pcp/message/14526
View All Messages In Topic (5): https://groups.io/g/pcp/topic/2881991
Mute This Topic: https://groups.io/mt/2881991?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-