Updates to Github #github

6 New Commits:

[parfait:master] By Nathan Scott <[email protected]>:
6a4c9d124595 ( https://github.com/performancecopilot/parfait/commit/6a4c9d124595c2d699f89285c81167c08ec081e9 ) : Fix ThreadContextTest failures for some log4j versions (#1) Failed tests: ThreadContextTest.testClearRemovesMDCValue:78 Expected: but was: {} (#2) Failed tests: ThreadContextTest.testClearRemovesMDCValue:89 expected:<0> but was:<1> (some debugging finds the {painter=7} hash entry to still be present) Evidently the newMDCEnabledContext() in log4j ThreadContext returns an empty hash for some versions, not null (case #1). It also seems that different deep/shallow ThreadContext hash copying behaviours can cause the test to fail (case #2).

Modified: parfait-core/src/test/java/io/pcp/parfait/timing/ThreadContextTest.java ( https://github.com/performancecopilot/parfait/blob/master/parfait-core/src/test/java/io/pcp/parfait/timing/ThreadContextTest.java )

[parfait:master] By Nathan Scott <[email protected]>:
2360d01723a5 ( https://github.com/performancecopilot/parfait/commit/2360d01723a54ad0c3083290815118c17efe25c4 ) : Update to v1.0 releases of unitsofmeasurement modules

Modified: pom.xml ( https://github.com/performancecopilot/parfait/blob/master/pom.xml )

[parfait:master] By Nathan Scott <[email protected]>:
289ac382e903 ( https://github.com/performancecopilot/parfait/commit/289ac382e903ba09293b8d95ef4287693ead518b ) : Update to a more recent version of hsqldb module

Modified: parfait-jdbc/pom.xml ( https://github.com/performancecopilot/parfait/blob/master/parfait-jdbc/pom.xml )

[parfait:master] By Nathan Scott <[email protected]>:
7dd43f002f7f ( https://github.com/performancecopilot/parfait/commit/7dd43f002f7f9cc216d9a21fb6691645fcc1a08b ) : Update to more recent version of dropwizard.io metrics module The one API breaking change affected ParfaitReporterFactoryTest, relatively straightforward to resolve by using the metrics class YamlConfigurationFactory (ConfigurationFactory now an interface). That caused this fallout... testBuildFromYamlConfiguration(io.pcp.parfait.dropwizard.ParfaitReporterFactoryTest) Time elapsed: 0.123 sec <<< ERROR! io.dropwizard.configuration.ConfigurationParsingException: /home/source/git/parfait/parfait-dropwizard/target/test-classes/io/pcp/parfait/dropwizard/metric-app.yml has an error: * Failed to parse configuration at: reporters.excludes; (was java.lang.NullPointerException) (through reference chain: io.dropwizard.metrics.MetricsFactory["reporters"]->io.pcp.parfait.dropwizard.ParfaitReporterFactory["excludes"]) ...which is resolved here by no longer having an empty "excludes" section in the metrics-app test YAML configuration file.

Modified: parfait-dropwizard/src/test/java/io/pcp/parfait/dropwizard/ParfaitReporterFactoryTest.java ( https://github.com/performancecopilot/parfait/blob/master/parfait-dropwizard/src/test/java/io/pcp/parfait/dropwizard/ParfaitReporterFactoryTest.java )
Modified: parfait-dropwizard/src/test/resources/io/pcp/parfait/dropwizard/metric-app.yml ( https://github.com/performancecopilot/parfait/blob/master/parfait-dropwizard/src/test/resources/io/pcp/parfait/dropwizard/metric-app.yml )
Modified: pom.xml ( https://github.com/performancecopilot/parfait/blob/master/pom.xml )

[parfait:master] By Nathan Scott <[email protected]>:
39206e02657d ( https://github.com/performancecopilot/parfait/commit/39206e02657d9e5fb03a194095467e5442272517 ) : Revert "Update to more recent version of dropwizard.io metrics module" This reverts commit 7dd43f002f7f9cc216d9a21fb6691645fcc1a08b. In this version io.dropwizard.metrics.BaseReporterFactory is using java.util.Optional from java 1.8 - so, looks like we can't upgrade this module until we're happy to accept java-1.8-or-later-only.

Modified: parfait-dropwizard/src/test/java/io/pcp/parfait/dropwizard/ParfaitReporterFactoryTest.java ( https://github.com/performancecopilot/parfait/blob/master/parfait-dropwizard/src/test/java/io/pcp/parfait/dropwizard/ParfaitReporterFactoryTest.java )
Modified: parfait-dropwizard/src/test/resources/io/pcp/parfait/dropwizard/metric-app.yml ( https://github.com/performancecopilot/parfait/blob/master/parfait-dropwizard/src/test/resources/io/pcp/parfait/dropwizard/metric-app.yml )
Modified: pom.xml ( https://github.com/performancecopilot/parfait/blob/master/pom.xml )

[parfait:master] By Nathan Scott <[email protected]>:
5bbef2658a6a ( https://github.com/performancecopilot/parfait/commit/5bbef2658a6a956f727fdf93c1801b04b80a1544 ) : Allow parfait.startup to be configured via properties Instead of essentially hard-coding the default startup time for apps, provide parfait-agent options to set this as per: https://github.com/performancecopilot/parfait/issues/32

Modified: bin/parfait.bat ( https://github.com/performancecopilot/parfait/blob/master/bin/parfait.bat )
Modified: bin/parfait.sh ( https://github.com/performancecopilot/parfait/blob/master/bin/parfait.sh )
Modified: parfait-agent/src/main/java/io/pcp/parfait/MonitoringViewProperties.java ( https://github.com/performancecopilot/parfait/blob/master/parfait-agent/src/main/java/io/pcp/parfait/MonitoringViewProperties.java )
Modified: parfait-agent/src/main/resources/agent.xml ( https://github.com/performancecopilot/parfait/blob/master/parfait-agent/src/main/resources/agent.xml )
Modified: parfait-agent/src/test/java/io/pcp/parfait/MonitoringViewPropertiesTest.java ( https://github.com/performancecopilot/parfait/blob/master/parfait-agent/src/test/java/io/pcp/parfait/MonitoringViewPropertiesTest.java )
Modified: parfait-agent/src/test/java/io/pcp/parfait/ParfaitAgentArgumentsTest.java ( https://github.com/performancecopilot/parfait/blob/master/parfait-agent/src/test/java/io/pcp/parfait/ParfaitAgentArgumentsTest.java )
Modified: parfait-agent/src/test/resources/test.properties ( https://github.com/performancecopilot/parfait/blob/master/parfait-agent/src/test/resources/test.properties )



---

[performancecopilot/parfait] Pull request closed by natoscott ( https://github.com/natoscott ) :

#35 Resolve minor issues for rpm-packaging builds of Parfait ( https://github.com/performancecopilot/parfait/pull/35 )