Re: PCP Updates: RHBZ 1348349: pmchart(1): Table of metrics, instances and values

----- Original Message -----
> I've pushed some more changes which address most of the comments below.

This is looking great, Dave - nice work.

> The one remaining item is to only pop-up one window when there is more
> than one view opened. I see that there is one window per chart opened,
> even when there are multiple tabs. That is, one window gets opened for
> each chart across all tabs. I'm not really sure how to prevent this.
> Each Chart object receives the "selected" signal and I can't see a way
> to tell which chart was actually clicked on. If anyone can point me in
> the right direction, it would be appreciated.

I think this should do it:
- you can find the tab at the top of the stack via PmChart::activeTab() 
- with that, you can find the active chart using Tab::currentGadget()
- the Chart class inherits from Gadget, so can test on equality with the
  current gadget to find the selected chart I think.

You might need to take special care with the order of event handling,
since you're also working with the same event that changes the current
selected chart, maybe (i.e. clicking on a chart).  Or it might Just Work,
as-is.

> FWIW, now the popped-up windows are no longer modal. Each can be moved
> aside and will be updated with each new click on the chart. It's not
> exactly what Nathan wanted, but not completely unusable anymore.

Looks good to me.  Resizing working nicely too - one thing that might
help with the final row (and its values) being "oversized" could be to
insert an extra, empty row at the end?  That way the vertical resize
(which isn't helpful for this dialog really) resizes that empty row
while all the data rows would look consistently sized.

Not sure why, but the Hostname column is always reporting "unknown" for
me for all values.  Gadget::hosts() might be worth perusing in terms of
other code that extracts hostnames from individual metrics.

cheers.

--
Nathan

-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14544): https://groups.io/g/pcp/message/14544
View All Messages In Topic (6): https://groups.io/g/pcp/topic/2881991
Mute This Topic: https://groups.io/mt/2881991?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-