Re: Parfait and UoM (java) RPM packages

Hi,

On 2016-10-21 01:32, Nathan Scott wrote:
> ----- Original Message -----
>> On 2016-10-20 04:17, Nathan Scott wrote:
>>>
>>>> X. Fix parfait-agent.jar, can be skipped when the fix is in the next RPM
>>>> build: unzip the jar, remove the top-most MANIFEST.MF, add the following
>>>> line to META-INF/MANIFEST.MF, and re-create the jar:
>>>>
>>>> Premain-Class: io.pcp.parfait.ParfaitAgent
>>>
>>> As mentioned on IRC, I think this is a packaging botch re the specific
>>> parfait-agent.jar file that ends up in the rpm - multiple jars are built
>>> but we don't use the correct one.  Will fix up on the next build.
>>
>> I'm still seeing the same issue with the -2 build:
>>
>> Failed to find Premain-Class manifest attribute in
>> /usr/share/java/parfait/parfait-agent.jar
>> Error occurred during initialization of VM
>> agent library failed to init: instrument
> 
> Sorry, we've passed each other like ships in the night.  The parfait-agent
> RPM was implemented in the -2 RPMs and that is the jar you'll need to use.
> Just to mix things up further, I named the standalone jar as "parfait.jar"
> now as in the Parfait README.md file, and forgot to tell you.  :P
> 
> So there is still a parfait-agent.jar in the parfait RPM, as you found -
> this is the jar that other applications could use if they want access to
> the parfait-agent code/resources (incl. JVM metric definition mbeans)
> directly.  But its not the standalone variety (its also smaller now).
> 
> All a bit confusing really, but good to get these things sorted out early
> on in the parfait-agent project lifecycle I suppose.

Sure, however now I'm able to get anything working with -2 :) After
removing parfait.rpm and its dependencies and then installing
parfait-agent.rpm with dnf (it had zero RPM dependencies), I'm getting:

[main] TRACE org.springframework.beans.TypeConverterDelegate - Field
[${parfait.name}] isn't an enum value
java.lang.NoSuchFieldException: ${parfait.name}
...
[main] ERROR io.pcp.parfait.ParfaitAgent - Stopping Parfait agent,
cannot setup beans
...

> I also put the proxying code in the -2 build if you want to try that out?
> But I forgot to put /usr/bin/parfait in... ho-hum... just to making life
> difficult - there'll be a -3 soon.

Thanks, let's see more advanced cases one the basics are robust.

>> You mean we'd need to wait for a possible future GSoC project to have
>> [...]
> 
> Oh, no - those are "nice to have" features really, to help people with
> adding new metrics.  If there are more JVM metrics you have classified
> (in terms of correct PCP metric metadata) they can be added directly to
> the mbeans file now - no need to wait.
> 
> Shouldn't have to - have a look at the parfait code, in the resources
> directory for parfait-agent (and the current mbeans definitions there) -
> we can certainly add more mbeans there.

In the parfait-agent.jar the only resources directory is
javax/servlet/resources but a cursory look or grep -i mbean found
nothing interesting so not quite sure where to look?

> Over time we want to be able to add those definitions externally to the
> parfait-agent jar, but it's not there yet.

That'd be much better, yes.

> I'll take a closer look - could you paste the full command line (or, just
> send it to me privately) & instructions to reproduce?

Basically following the steps I sent earlier, after PCP is installed:

java -cp .:/usr/share/java/parfait
-javaagent:/usr/share/java/parfait/parfait.jar HelloWorld

(The same end result with or without -cp).

Thanks,

-- 
Marko Myllynen

-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14569): https://groups.io/g/pcp/message/14569
View All Messages In Topic (22): https://groups.io/g/pcp/topic/2895998
Mute This Topic: https://groups.io/mt/2895998?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-