Re: PCP Updates: RHBZ 1348349: pmchart(1): Table of metrics, instances and values
"Nathan Scott" <[email protected]>
| Newsgroups | gmane.comp.sysutils.pcp |
|---|---|
| Message-ID | <[email protected]> |
Hi Dave,
----- Original Message -----
> On 10/20/2016 09:10 PM, Nathan Scott wrote:
> > The only other thing I can suggest is a little code refactoring. I notice
> > the code implementing the new dialog is inline in chart.cpp - most of that
> > code looks like it belongs in the separate metricsdialog.{h,cpp}. That'd
> > require the passing of a "Chart*" into some of the MetricsDialog routines,
> > and it'll keep those independent concerns a bit more separated.
> >
> > Have a look at chartdialog.{h,cpp} as an example of that pattern. For
> > reference that's the dialog that gets popped up if you select "New Chart"
> > or "Edit Chart" from the main menu.
> >
> I think that this takes care of the above. Ifyou agree, then I think
> that this is ready to merge.
>
+1 - pulled in with most remaining stuff today for this pending release.
There's a handful of small self-contained fixes (Mark has some, Lukas, one
more from Marko I think), but we're pretty close to done & QA is ramping up
here at least.
cheers.
--
Nathan
-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:
You receive all messages sent to this group.
View/Reply Online (#14667): https://groups.io/g/pcp/message/14667
View All Messages In Topic (12): https://groups.io/g/pcp/topic/2881991
Mute This Topic: https://groups.io/mt/2881991?uid=174580
New Topic: https://groups.io/g/pcp/post
Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580
Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]
Terms of Service: https://groups.io/static/tos
Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-