Re: zbxpcp.so: update module.h from upstream 3.2.1

Hi,

On 2016-11-09 08:18, Nathan Scott wrote:
> ----- Original Message -----
>> [...]
>> Zabbix Agent module API has been changed, every existing binary is
>> broken and we need to adjust our local module.h copy.
> 
> Ouch.  We may be able to workaround this the same way we did last time
> - if we can find a symbol newly added in zabbix 3.2 we could use dlsym
> heuristics again. 
> 
>> Zabbix 3.2 is available from their repos for RHEL 5 and newer, I don't
>> think we need to preserve source level compatibility with API version 1.
> 
> *nod* - its more the existing zbxpcp.so installed base we need to worry
> about, which would break for all pre-3.2 zabbix versions (i.e. if we go
> with that patch, next PCP upgrade will break pretty much everyone using
> zbxpcp.so).
> 
> Attached patch is an initial tweak on the PCP code, which should do all
> the right things once its "zbx_xxxxxx" is replaced with an appropriate
> function name, and hopefully will then work for all Zabbix versions.  Any
> ideas on a symbol we could use?  (perhaps something related to this new
> "history" functionality)

Good idea (again) - your patch with two additional changes works with
both 3.0.5 and 3.2.1:

- use history_log_cbs as the symbol to check
- call zbx_get_version() in zbx_module_api_version(), not in
zbx_module_init()

Thanks,

-- 
Marko Myllynen

-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14670): https://groups.io/g/pcp/message/14670
View All Messages In Topic (3): https://groups.io/g/pcp/topic/2992464
Mute This Topic: https://groups.io/mt/2992464?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-