nfsclient PMDA question
"Ken McDonell" <[email protected]>
| Newsgroups | gmane.comp.sysutils.pcp |
|---|---|
| Message-ID | <[email protected]> |
Martins, This is coming to you via git-blame ... 8^) In the nfsclient PMDA, there are several metrics that are given their PCP type via the pmda_ulong() method. I've just discovered that this method is wrong and has (forever?) been returning the signed, not the unsigned type. I've fixed the Perl module code (commit coming) for pmda_ulong(), but my question is what type _should_ these metrics be in the nfsclient PMDA? Given the prevalence of explicit unsigned for other metrics in this PMDA, I'm guessing "unsigned" is the answer. It probably does not matter in terms of data semantics, because even on 32-bit platforms, these counters may be unlikely to wrap. The real issue is extant pmlogger archives. If the numbers should be signed, then I'll change the PMDA to use pmda_long() instead of pmda_ulong(). If the numbers should be unsigned, then I'll need a pmlogrewrite config to ensure pmlogextract can merge archives from before and after the change to the PCP::PMDA module. Fortunately, the fallout from the perl module change is likely to be limited ... kenj@bozo:~/src/pcp$ grep -Rl pmda_ulong src qa 2>/dev/null | grep -v src/perl/PMDA src/pmdas/nfsclient/pmdanfsclient.pl qa/798 And I just added the qa/798 one (debugging failures of this test on 32-bit platforms led to identifying the perl module problem). -=-=-=-=-=-=-=-=-=-=-=- pcp mailing list [email protected] https://groups.io/g/pcp/messages -=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#14745): https://groups.io/g/pcp/message/14745 View All Messages In Topic (1): https://groups.io/g/pcp/topic/3153837 Mute This Topic: https://groups.io/mt/3153837?uid=174580 New Topic: https://groups.io/g/pcp/post Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580 Group Home: https://groups.io/g/pcp Contact Group Owner: [email protected] Terms of Service: https://groups.io/static/tos Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy -=-=-=-=-=-=-=-=-=-=-=-