Re: Pull Request Closed #github #java

I think the github integration is reporting incorrectly. I pushed some 
new changes to the branch associated with the PR but the integration is 
thinking that I've closed it. The PR is still open in github.


On 20/11/16 12:06, Pcp Integration wrote:
> [performancecopilot/parfait] Pull request closed by ryandoyle
> <https://github.com/ryandoyle>:
>
> #39 Implement MMV V2 support
> <https://github.com/performancecopilot/parfait/pull/39>
> This branch implements support for Parfait to write the MMV V2 format.
> The approach I settled on was to implement V1/2 of `Instance` and
> `PcpMetricInfo`s. The responsibility of writing to the MMV file was
> moved to these domain classes themselves. There is a small bit of
> variance in the performance tests but I'd say its within an acceptable
> range. ``` MMV V2 pcpStarted: false perMetricLock: false
> incrementRate(/sec): 51,880,674.45 blockedCount: 0 blockedTime: 0
> pcpStarted: true perMetricLock: false incrementRate(/sec): 3,620,564.81
> blockedCount: 4158 blockedTime: 386 pcpStarted: true perMetricLock: true
> incrementRate(/sec): 3,749,882.82 blockedCount: 180 blockedTime: 21
> pcpStarted: true perMetricLock: true incrementRate(/sec): 3,819,709.70
> blockedCount: 138 blockedTime: 10 pcpStarted: true perMetricLock: false
> incrementRate(/sec): 3,891,050.58 blockedCount: 1903 blockedTime: 350
> pcpStarted: false perMetricLock: false incrementRate(/sec):
> 111,111,111.11 blockedCount: 0 blockedTime: 0 MMV V1 - refactored
> pcpStarted: false perMetricLock: false incrementRate(/sec):
> 52,910,052.91 blockedCount: 5 blockedTime: 0 pcpStarted: true
> perMetricLock: false incrementRate(/sec): 3,616,309.56 blockedCount:
> 3921 blockedTime: 353 pcpStarted: true perMetricLock: true
> incrementRate(/sec): 3,808,073.12 blockedCount: 149 blockedTime: 9
> pcpStarted: true perMetricLock: true incrementRate(/sec): 3,950,617.28
> blockedCount: 66 blockedTime: 14 pcpStarted: true perMetricLock: false
> incrementRate(/sec): 3,977,329.22 blockedCount: 1688 blockedTime: 440
> pcpStarted: false perMetricLock: false incrementRate(/sec):
> 94,562,647.75 blockedCount: 0 blockedTime: 0 MMV V1 - original code
> pcpStarted: false perMetricLock: false incrementRate(/sec):
> 53,981,106.61 blockedCount: 4 blockedTime: 0 pcpStarted: true
> perMetricLock: false incrementRate(/sec): 3,660,992.13 blockedCount:
> 5240 blockedTime: 462 pcpStarted: true perMetricLock: true
> incrementRate(/sec): 3,844,305.62 blockedCount: 141 blockedTime: 18
> pcpStarted: true perMetricLock: true incrementRate(/sec): 3,916,960.44
> blockedCount: 92 blockedTime: 28 pcpStarted: true perMetricLock: false
> incrementRate(/sec): 3,958,828.19 blockedCount: 1865 blockedTime: 397
> pcpStarted: false perMetricLock: false incrementRate(/sec):
> 106,666,666.67 blockedCount: 1 blockedTime: 1 ```
>
> 

-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14749): https://groups.io/g/pcp/message/14749
View All Messages In Topic (2): https://groups.io/g/pcp/topic/3154092
Mute This Topic: https://groups.io/mt/3154092?uid=174580
New Topic: https://groups.io/g/pcp/post

Mute Topics Tagged With #github: https://groups.io/mk?hashtag=github&subid=354243

Mute Topics Tagged With #java: https://groups.io/mk?hashtag=java&subid=354243

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-