New Comment on Pull Request #github

[pcp:master] New Comment on Pull Request #271 Develop buddyinfo ( https://github.com/performancecopilot/pcp/pull/271 )
By natoscott ( https://github.com/natoscott ) :

@s-miyoshi-fj nice work, thanks!

One thing that stands out is that the instance names don't adhere to the rules described on pmdaCacheOp(3). See paragraph 2 in that man page, starting "The semantics of a PCP instance domain require a number of rules to be followed, namely:".

In particular, the names are not unique to the left of the first space. I suggest going with the following naming convention here instead:

inst [10 or "DMA_2048:node0"] value 3 inst [11 or "DMA32_2:node0"] value 379

etc. I think the 2^N notation is a bit confusing (not used anywhere else in PCP), so maybe just spell it out like above. The NUMA node part should match with the NUMA node names used for other metrics, e.g. see "pminfo -fmdTt hinv.node.online".