Re: RFC: metric labels as first-class PCP concept
"Nathan Scott" <[email protected]>
| Newsgroups | gmane.comp.sysutils.pcp |
|---|---|
| Message-ID | <[email protected]> |
----- Original Message ----- > > [...] OK, see attached patch - v2. This is a fairly large update, > > starting to spec out more of the PMDA side of things now as well and > > incorporate the feedback so far. > > Thank you, you're obviously working hard on this. You have sketched out > more aspects of the representation and a couple aspects of data flow. > > > (not yet profiles or archives though) > > The profiles part is important, [...] Yes, of course (as are archives), that was why I mentioned 'em as not here yet. > This looks very simple, which is good. Its very lightweight too, which is great. > how do you imagine this > being used by tools [...] not simply > to call pmLookupLabels() after every pmFetch() - that'd be huge new > overhead. FWLIW, that "huge overhead" is essentially what you're half-proposing (although inline in the fetch, not after-the-fact - but same overhead otherwise). So, definitely not that. The model is more like handling instances as (if) they change, as I mentioned before several times now. > [...] the PMCD_LABEL_CHANGE pmFetch > result-flag indicating any labeling change? Yes, at this stage - label change seems sufficiently infrequent a thing that this may well a good approach. That's the plan for the initial prototype anyway, and will evaluate it then. Its not hard to imagine how that will look on the pmda/pmcd side, so I've left that as just an implementation detail for now, not needing explicit design docs. > > - switches space-separated name=value pairs to JSONB > > What does "JSONB" mean in this context? It's clearly defined in pmlabel(1) from the patch... SYNTAX Labels are stored and communicated within PCP using JSONB format. This format is a restricted form of JSON suitable for indexing and other operations. In JSONB form, insignificant whitespace is discarded, and the order of object keys is not preserved. Duplicate object keys are not kept - the later value for a given key is the only one stored. cheers. -- Nathan -=-=-=-=-=-=-=-=-=-=-=- pcp mailing list [email protected] https://groups.io/g/pcp/messages -=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#14868): https://groups.io/g/pcp/message/14868 View All Messages In Topic (19): https://groups.io/g/pcp/topic/3188520 Mute This Topic: https://groups.io/mt/3188520?uid=174580 New Topic: https://groups.io/g/pcp/post Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580 Group Home: https://groups.io/g/pcp Contact Group Owner: [email protected] Terms of Service: https://groups.io/static/tos Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy -=-=-=-=-=-=-=-=-=-=-=-