Re: RFC: metric labels as first-class PCP concept
"Frank Ch. Eigler" <[email protected]>
| Newsgroups | gmane.comp.sysutils.pcp |
|---|---|
| Message-ID | <[email protected]> |
Hi -
> > [...] the PMCD_LABEL_CHANGE pmFetch
> > result-flag indicating any labeling change?
>
> Yes, at this stage - label change seems sufficiently infrequent a thing
> that this may well a good approach. That's the plan for the initial
> prototype anyway, and will evaluate it then. Its not hard to imagine
> how that will look on the pmda/pmcd side, so I've left that as just an
> implementation detail for now, not needing explicit design docs.
Other than the complications I listed in just computing that flag at
the sender side, the receiver side has no information about which
labels may have changed. It'd have to re-query every metric & every
indom. It's not hard to imagine it working badly, so design docs
would still be appropriate.
> > > - switches space-separated name=value pairs to JSONB
> >
> > What does "JSONB" mean in this context?
>
> It's clearly defined in pmlabel(1) from the patch...
>
> SYNTAX
> Labels are stored and communicated within PCP using JSONB format. [...]
But that description talks about internal interpretation / behaviour,
not about actual *formatting*. For that, you'd want to talk about
what constraints the data parser parser. e.g., would it accept
{"hello":"world"\n}
in a configuration file? It should also describe what guarantees it
offers about its textual output, for a consumer program to assume:
e.g., any whitespace? That's a format specification.
- FChE
-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:
You receive all messages sent to this group.
View/Reply Online (#14870): https://groups.io/g/pcp/message/14870
View All Messages In Topic (20): https://groups.io/g/pcp/topic/3188520
Mute This Topic: https://groups.io/mt/3188520?uid=174580
New Topic: https://groups.io/g/pcp/post
Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580
Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]
Terms of Service: https://groups.io/static/tos
Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-