Re: PCP Updates RHBZ 1359975: pmchart run-away mem leak replaying multi-archive when rewinding

This commit is required on top of the previous one to fix the qa 
fallout. Please review with both commits merged.

Thanks,
Dave

--------------------------------------------------------------------------------------------------------

Changes committed to ssh://git.pcp.io/oss/git/brolley/pcp master

Dave Brolley (1):
       RHBZ 1359975: pmchart run-away mem leak replaying multi-archive 
when rewinding

  src/libpcp/src/logmeta.c |  126 
+++++++++++++++++++++++++++++++++++------------
  1 file changed, 96 insertions(+), 30 deletions(-)

Details ...

commit 82e02ffea204d26e7617a4bcf4be0b9326c64457
Author: Dave Brolley <[email protected]>
Date:   Mon Dec 12 14:39:09 2016 -0500

     RHBZ 1359975: pmchart run-away mem leak replaying multi-archive 
when rewinding

     Refinement. Exposed by qa regressions. Ensure that instance domains 
are in
     the correct order in the hash chain:

     - Primary sort by timestamp (descending)
     - Secondary sort: latest added at the head of each time slot. This
       includes moving duplicates to the head of their time slot when 
detected.

     Before multi-archive contexts and duplicate-filtering, this happened
     automatically.

On 12/08/2016 12:39 PM, Dave Brolley wrote:
> If you're reviewing this change, please hold off on merging it. I'm 
> working through some qa fallout.
>
> Dave
>
> On 12/07/2016 11:59 AM, Dave Brolley wrote:
>> These changes fix the memory leaks detected by fche and mgoodwin. 
>> There is still a performance issue which was exposed (not caused) by 
>> these changes. That is best track by a separate bug report.
>>
>> ------------------------------------------------------------------------------------------------------- 
>>
>> Changes committed to git://git.pcp.io/brolley/pcp rhbz1359975
>>
>> Dave Brolley (1):
>>       RHBZ 1359975: pmchart run-away mem leak replaying multi-archive 
>> when rewinding
>>
>>  src/libpcp/src/logmeta.c |   83 
>> ++++++++++++++++++++++++++++++++++++++++++-----
>>  1 file changed, 75 insertions(+), 8 deletions(-)
>>
>> Details ...
>>
>> commit 0015487d1fd1c70f94bb75b08109a13de81dc878
>> Author: Dave Brolley <[email protected]>
>> Date:   Wed Dec 7 11:50:40 2016 -0500
>>
>>     RHBZ 1359975: pmchart run-away mem leak replaying multi-archive 
>> when rewinding
>>
>>     Two leaks were fixed. Both occurred during the transition between 
>> archives
>>     is a multi-archive context.
>>
>>     1) a leak of pmDesc * used to check for consistency of the PMNS
>>        between archives.
>>
>>     2) a build up of duplicate instance domains.
>>
>>
>>
>>
>
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14891): https://groups.io/g/pcp/message/14891
View All Messages In Topic (4): https://groups.io/g/pcp/topic/3763263
Mute This Topic: https://groups.io/mt/3763263?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-