Re: [Bug 1359975] pmchart run-away mem leak replaying multi-archive when rewinding

Thanks -- I've picked up the style/typo patch, including the final typo 
for __pmLogIndom. Working on the rest.

Hopefully Ken knows whether we can rely on consistent ordering of 
instances and instance names. If not, the current implementation would 
miss some duplicates. FWIW, the massive build up of duplicates displayed 
by Mark's test case was tamed by the current implementation, suggesting 
that most, if not all, of the duplicates in those archives were sorted 
in the same way.

Dave

On 12/12/2016 10:39 PM, Nathan Scott wrote:
> Hi Dave,
>
> ----- Original Message -----
>> https://bugzilla.redhat.com/show_bug.cgi?id=1359975
>>
>> --- Comment #17 from Dave Brolley <[email protected]> ---
>> Additional proposed commit (on top of the previous one):
>>
>> In the tree/branch:  git://git.pcp.io/brolley/pcp rhbz1359975
>>
>> commit 82e02ffea204d26e7617a4bcf4be0b9326c64457
>> Author: Dave Brolley <[email protected]>
>> Date:   Mon Dec 12 14:39:09 2016 -0500
>>
>>      RHBZ 1359975: pmchart run-away mem leak replaying multi-archive when
>> rewinding
>>
>>      Refinement. Exposed by qa regressions. Ensure that instance domains are
>>      in the correct order in the hash chain:
>>
>>      - Primary sort by timestamp (descending)
>>      - Secondary sort: latest added at the head of each time slot. This
>>        includes moving duplicates to the head of their time slot when
>>        detected.
>>
>>      Before multi-archive contexts and duplicate-filtering, this happened
>>      automatically.
> Couple things - the new sameindom() routine seems to assuming the instance
> IDs and names are sorted in some way (i.e. direct array comparison can be
> done, rather than iterating through the 2nd array for each element in the
> 1st - is that the case?)  Not sure.
>
> Other, small thing - it would be more efficient to add __pmtimevalCmp into
> libpcp now I think (its in libpcp_gui for hysterical raisins IIRC), so it's
> available for use here instead of using floating point math & comparisons
> as is being done for the timestamps now.
>
> Attached patch has some minor pcp-style and typo cleanups.
>
> cheers.
>
> --
> Nathan


-=-=-=-=-=-=-=-=-=-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14894): https://groups.io/g/pcp/message/14894
View All Messages In Topic (1): https://groups.io/g/pcp/topic/3803079
Mute This Topic: https://groups.io/mt/3803079?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-