Re: [Bug 1359975] pmchart run-away mem leak replaying multi-archive when rewinding

"Nathan Scott" <[email protected]>
Newsgroups gmane.comp.sysutils.pcp
Message-ID <[email protected]>
Hi Dave,

----- Original Message -----
> Please find attached 3 proposed patches:
> 
> *__pmTimevalCmp.patch.txt*: __pmtimevalCmp() takes two arguments of
> type 'struct timeval' where we want to compare two arguments of type
> __pmTimeval. Rather than introduce the inconvenience and inefficiency of
> converting before comparing, I created a similar new function,
> __pmTimevalCmp() to compare them directly.
> 
> *ordered.patch.txt*: Uses memcmp within sameindom() to compare the
> instances, assuming that the instances within instance domains will
> always be ordered in the same way.
> 
> *unordered.patch.txt*: Alternate implementation of sameindom() to be
> used if we can not assume that the instances within instance domains
> will always be ordered in the same way.
> 

These patches look good to me.

cheers.

--
Nathan

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14900): https://groups.io/g/pcp/message/14900
View All Messages In Topic (3): https://groups.io/g/pcp/topic/3803079
Mute This Topic: https://groups.io/mt/3803079?uid=174580
New Topic: https://groups.io/g/pcp/post

Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580

Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]

Terms of Service: https://groups.io/static/tos

Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy

-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-=-=-=-=-=-=-=-=-=-
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.