Re: [Bug 1359975] pmchart run-away mem leak replaying multi-archive when rewinding
"Nathan Scott" <[email protected]>
| Newsgroups | gmane.comp.sysutils.pcp |
|---|---|
| Message-ID | <[email protected]> |
Hi Ken, ----- Original Message ----- > On 16/12/16 10:33, Nathan Scott wrote: > > ----- Original Message ----- > >> [...] > >> *ordered.patch.txt*: Uses memcmp within sameindom() to compare the > >> instances, assuming that the instances within instance domains will > >> always be ordered in the same way. > >> > >> *unordered.patch.txt*: Alternate implementation of sameindom() to be > >> used if we can not assume that the instances within instance domains > >> will always be ordered in the same way. > > > > I came across the metric "sample.scramble.bin" today, which should be > > able to provide a definitive test case here such that the above (open > > question re sorting) can be answered... > > Re the "open" question ... in my mind, and instance domain is a > (mathematical) set, so there is no assumed order. Yep, definitely, and that aspect is understood here I think. However... > Indeed, PMAPI clients that really care when an instance domain changes > typically check instances returned from pmFetch by either doing the > (potentially n^2) exhaustive search (like pmlogger) or sorting the > pmValueSet on internal instance id (like pmie). ... at the point that Dave was hacking in libpcp, all instances seemed to have been sorted at some point along the pipeline before that point. But we couldn't identify where that was (if it was indeed the case) - so the above metric (logged, and then observed at the point of interest) is hopefully going to provide an acid test for that case. cheers. -- Nathan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#14912): https://groups.io/g/pcp/message/14912 View All Messages In Topic (6): https://groups.io/g/pcp/topic/3803079 Mute This Topic: https://groups.io/mt/3803079?uid=174580 New Topic: https://groups.io/g/pcp/post Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580 Group Home: https://groups.io/g/pcp Contact Group Owner: [email protected] Terms of Service: https://groups.io/static/tos Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy -=-=- pcp mailing list [email protected] https://groups.io/g/pcp/messages -=-=-=-=-=-=-=-=-=-=-=-