Re: additional metrics of zoneinfo

Hi Liming,

----- Original Message -----
> Hi:
>    
>    This patch add some information from /proc/zoneinfo
>    I think those information is useful for performance analysis.
>    please refer to the attachment for the details.
> 

Looks good, I've merged most of it.  One aspect I'm unsure about
is the "protected" value(s).  The patch picks out the fourth proc
zoneinfo field from that line - why that one?  Looking inside the
kernel code (mm/vmstat.c::zoneinfo_show_print)

        seq_printf(m,
                   "\n        protection: (%ld",
                   zone->lowmem_reserve[0]);
        for (i = 1; i < ARRAY_SIZE(zone->lowmem_reserve); i++)
                seq_printf(m, ", %ld", zone->lowmem_reserve[i]);

and the definition of the struct zone lowmem_reserve array (from
include/linux/mmzone.h) - I think that this metric should possibly
be using a separate indom to present all of these lowmem_reserve'd
values?

(so, I'll leave the mem.zoneinfo.protection metric out for now -
until we can resolve that part.  I've also updated test qa/821.)

cheers.

--
Nathan

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#14951): https://groups.io/g/pcp/message/14951
View All Messages In Topic (2): https://groups.io/g/pcp/topic/3858433
Mute This Topic: https://groups.io/mt/3858433?uid=174580
New Topic: https://groups.io/g/pcp/post
-=-=-
pcp mailing list
[email protected]
https://groups.io/g/pcp/messages
-=-=-
Change Your Subscription: https://groups.io/g/pcp/editsub?uid=174580
Group Home: https://groups.io/g/pcp
Contact Group Owner: [email protected]
Terms of Service: https://groups.io/static/tos
Unsubscribe: https://groups.io/g/pcp/leave/354243/563757577/xyzzy
-=-=-=-=-=-=-=-=-=-=-=-