| Newsgroups |
gmane.comp.sysutils.pcp |
| Message-ID |
<[email protected]> |
9 New Commits:
[pcp:master] By Lukas Berk <[email protected]>:
b72b6fe3e697 ( https://github.com/performancecopilot/pcp/commit/b72b6fe3e6971d11ff761f15e19abd225cf9c2ab ) : pmdadocker: metrics via docker's remote api This is a multithreaded pmda. One thread is in use for docker api queries, some of which can take an extended amount of time, and the other is used for responses from client tools Due to the http requests returning a string, libpcp_web had to be tweaked to include both a new pmjson function pmjsonInitChar as well as tweaking the http_fetching to enable changing the request to match the needs of the docker api A valgrind test has been included in the qa
Added: qa/924 ( https://github.com/performancecopilot/pcp/blob/master/qa/924 )
Added: qa/924.out ( https://github.com/performancecopilot/pcp/blob/master/qa/924.out )
Added: src/pmdas/docker/GNUmakefile ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/GNUmakefile )
Added: src/pmdas/docker/Install ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/Install )
Added: src/pmdas/docker/Remove ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/Remove )
Added: src/pmdas/docker/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/docker.c )
Added: src/pmdas/docker/domain.h ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/domain.h )
Added: src/pmdas/docker/help ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/help )
Added: src/pmdas/docker/pmns ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/pmns )
Added: src/pmdas/docker/root ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/root )
Modified: qa/group ( https://github.com/performancecopilot/pcp/blob/master/qa/group )
Modified: src/include/pcp/pmjson.h ( https://github.com/performancecopilot/pcp/blob/master/src/include/pcp/pmjson.h )
Modified: src/libpcp_web/src/exports ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/exports )
Modified: src/libpcp_web/src/http_client.c ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/http_client.c )
Modified: src/libpcp_web/src/http_parser.h ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/http_parser.h )
Modified: src/libpcp_web/src/json_helpers.c ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/json_helpers.c )
Modified: src/pmdas/GNUmakefile ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/GNUmakefile )
Modified: src/pmns/stdpmid.pcp ( https://github.com/performancecopilot/pcp/blob/master/src/pmns/stdpmid.pcp )
[pcp:master] By Lukas Berk <[email protected]>:
003867aeaa38 ( https://github.com/performancecopilot/pcp/commit/003867aeaa3826f1054d92125a007d7443969d51 ) : Integrate various feedback to pmdadocker
Modified: qa/924 ( https://github.com/performancecopilot/pcp/blob/master/qa/924 )
Modified: src/pmdas/docker/Remove ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/Remove )
Modified: src/pmdas/docker/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/docker.c )
[pcp:master] By Lukas Berk <[email protected]>:
64a6ee173f6d ( https://github.com/performancecopilot/pcp/commit/64a6ee173f6d0dc1978bb1fedbcb22bb8871e6c2 ) : pmdadocker - rework json interface for callback approach pmjsoninit.3 - update documentation qa/924{,.out} - update testsuite with helgrind tool json_test.c - update testcase with callback exports - remove pmjsoninitchar interface json_helpers.c - remove pmjsoninitchar and change pmjsoninit{,indom} to use callback for filling in the buffer with the JSON docment docker/docker.c - update pmdadocker with feedback root/docker.c - update pmdaroot with new interface
Modified: man/man3/pmjsoninit.3 ( https://github.com/performancecopilot/pcp/blob/master/man/man3/pmjsoninit.3 )
Modified: qa/924 ( https://github.com/performancecopilot/pcp/blob/master/qa/924 )
Modified: qa/924.out ( https://github.com/performancecopilot/pcp/blob/master/qa/924.out )
Modified: qa/src/json_test.c ( https://github.com/performancecopilot/pcp/blob/master/qa/src/json_test.c )
Modified: src/include/pcp/pmjson.h ( https://github.com/performancecopilot/pcp/blob/master/src/include/pcp/pmjson.h )
Modified: src/libpcp_web/src/exports ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/exports )
Modified: src/libpcp_web/src/json_helpers.c ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/json_helpers.c )
Modified: src/pmdas/docker/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/docker.c )
Modified: src/pmdas/root/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/root/docker.c )
[pcp:master] By Lukas Berk <[email protected]>:
0c9e04600d9d ( https://github.com/performancecopilot/pcp/commit/0c9e04600d9daac00a600db9026e56bb3954e430 ) : Restore inital json interfaces we can't just drop the inital interfaces for pmjsonInit and pmjsonInitIndom Instead, we'll create a default compat callback and have them both call pmjsonInitIterable immediately, which will do the heavy lifting.
Modified: qa/src/json_test.c ( https://github.com/performancecopilot/pcp/blob/master/qa/src/json_test.c )
Modified: src/include/pcp/pmjson.h ( https://github.com/performancecopilot/pcp/blob/master/src/include/pcp/pmjson.h )
Modified: src/libpcp_web/src/exports ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/exports )
Modified: src/libpcp_web/src/json_helpers.c ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/json_helpers.c )
Modified: src/pmdas/docker/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/docker.c )
Modified: src/pmdas/root/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/root/docker.c )
[pcp:master] By Nathan Scott <[email protected]>:
94f0c9fa2c72 ( https://github.com/performancecopilot/pcp/commit/94f0c9fa2c7271bf8c8d517ecc119ed2604da210 ) : libpcp_web: JSON API coding consistency, small improvements and fixes Mainly work on the iterable routine to get the callback to match the simpler semantics of read(2) as originally intended. Rename routine for the long-term, as the former was too much of a mouthful (my poor naming choice earlier). Update and use the typedef that was earlier added to pmjson.h for callback function. Fix compiler warning - json_helpers.c:376:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] int fd = (int)extra; Fix memleak of buffers in several locations. Numerous cleanups in terms of using static routines, switching pmdaroot over to pmjsonGet use and use fread since its using that sort of file I/O not fds, and so on. Make variable names shorter sometimes for better code layout and consistency with rest of PCP, without losing clarity I hope. Fixed typo in the libpcp_web exports file. Update the pmjson(3) man page as it was out of date in some places before starting tidying, but also add in the new API tweaks there.
Added: man/man3/pmjsonget.3 ( https://github.com/performancecopilot/pcp/blob/master/man/man3/pmjsonget.3 )
Added: src/pmdas/docker/.gitignore ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/.gitignore )
Removed: man/man3/pmjsoninit.3 ( https://github.com/performancecopilot/pcp/blob/master/man/man3/pmjsoninit.3 )
Modified: debian/libpcp-web1-dev.install ( https://github.com/performancecopilot/pcp/blob/master/debian/libpcp-web1-dev.install )
Modified: src/include/pcp/pmjson.h ( https://github.com/performancecopilot/pcp/blob/master/src/include/pcp/pmjson.h )
Modified: src/libpcp_web/src/exports ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/exports )
Modified: src/libpcp_web/src/json_helpers.c ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/json_helpers.c )
Modified: src/libpcp_web/src/private.h ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/private.h )
Modified: src/pmdas/docker/Remove ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/Remove )
Modified: src/pmdas/docker/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/docker.c )
Modified: src/pmdas/docker/pmns ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/pmns )
Modified: src/pmdas/root/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/root/docker.c )
Modified: src/pmdas/root/root.h ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/root/root.h )
[pcp:master] By Nathan Scott <[email protected]>:
5aa579892671 ( https://github.com/performancecopilot/pcp/commit/5aa5798926712a839fe6de204278a97ecc5af8b5 ) : libpcp_web: correct the json bytes offset/pointer calculation Ensure the correct buffer offset is used when copying data.
Modified: src/libpcp_web/src/json_helpers.c ( https://github.com/performancecopilot/pcp/blob/master/src/libpcp_web/src/json_helpers.c )
[pcp:master] By Nathan Scott <[email protected]>:
df491530106b ( https://github.com/performancecopilot/pcp/commit/df491530106be9788434d767c5be2f47bc353af4 ) : pmdadocker: final round of cleanup for now, minor fixes. Small edge case fix - incl. handling the case of no containers running. Also go back to the previous strdup usage on refresh thread, earlier change there was not correct and crashes.
Modified: src/pmdas/docker/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/docker.c )
Modified: src/pmdas/root/docker.c ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/root/docker.c )
[pcp:master] By Nathan Scott <[email protected]>:
e95dfde0fc9c ( https://github.com/performancecopilot/pcp/commit/e95dfde0fc9c4100b61ed81a2a658c478b72ea02 ) : qa: update filters for pmdadocker, additional net interfaces
Modified: qa/581 ( https://github.com/performancecopilot/pcp/blob/master/qa/581 )
Modified: qa/common.filter ( https://github.com/performancecopilot/pcp/blob/master/qa/common.filter )
[pcp:master] By Lukas Berk <[email protected]>:
ae5564fb50a2 ( https://github.com/performancecopilot/pcp/commit/ae5564fb50a21e6bb6b13a5179263202416844d5 ) : Add pmdadocker manpage
Added: src/pmdas/docker/pmdadocker.1 ( https://github.com/performancecopilot/pcp/blob/master/src/pmdas/docker/pmdadocker.1 )