| Newsgroups |
gmane.comp.sysutils.pcp |
| Message-ID |
<[email protected]> |
--yabbadabbadoo
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
[pcp:master] New Comment on Pull Request #277 perfevent_pmda: Add PMU event=
s exported from kernel ( https://github.com/performancecopilot/pcp/pull/277=
)
By hkshaw1990 ( https://github.com/hkshaw1990 ) :
@natoscott thanks for the review Nathan. Will add the suggested QAs for th=
e perfevent. While I agree that, a hyphen is illegal for a metric name to h=
ave, but, why a dot? The reason I am a bit unhappy to change everything to =
underscore because of some resultant metrics names. There is a "cpu" pmu in=
/sys/bus/event_source/devices and "cpu-cycles" is one of its events. If ev=
ery disallowed character is changed to underscore then the resultant name i=
s : perfevent.hwcounters.cpu_cpu_cycles.value So, atleast, can we have the =
dot separating the PMU name and the event name?
@fche Agreed to have some test case to check against a real running kernel=
. But, one issue which we can face there is how do we compare the test resu=
lts? Since, we don't know what or how many events are exposed in that kerne=
l. Can you please provide some suggestions to it?
Thanks!
--yabbadabbadoo
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
[pcp:master] New Comment on Pull Request <a href=3D"https://github.com/per=
formancecopilot/pcp/pull/277">#277 perfevent_pmda: Add PMU events exported =
from kernel</a><br>
By <a href=3D"https://github.com/hkshaw1990">hkshaw1990</a>:<p>
<p>@natoscott thanks for the review Nathan.
Will add the suggested QAs for the perfevent.
While I agree that, a hyphen is illegal for a metric name to have, but, wh=
y a dot? The reason I am a bit unhappy to change everything to underscore b=
ecause of some resultant metrics names. There is a "cpu" pmu in =
/sys/bus/event_source/devices and "cpu-cycles" is one of its even=
ts. If every disallowed character is changed to underscore then the resulta=
nt name is :
perfevent.hwcounters.cpu_cpu_cycles.value
So, atleast, can we have the dot separating the PMU name and the event nam=
e?</p>
<p>@fche Agreed to have some test case to check against a real running ker=
nel. But, one issue which we can face there is how do we compare the test r=
esults? Since, we don't know what or how many events are exposed in that ke=
rnel. Can you please provide some suggestions to it?</p>
<p>Thanks!</p>
<p>
<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target=3D"_blank" href=3D"https://groups.io/g/pcp/message/15238">View/R=
eply Online (#15238)</a> |
<a target=3D"_blank" href=3D"mailto:[email protected]?subject=3DRe:%20%5Bpcp=
%5D%20%5Bpcp%3Amaster%5D%20reported%3A%20perfevent_pmda%3A%20Add%20PMU%20ev=
ents%20exported%20from%20kernel%20%23github">Reply To Group</a>
| <a target=3D"_blank" href=3D"mailto:?subject=3DRe:%20%5Bpcp%5D%20%5B=
pcp%3Amaster%5D%20reported%3A%20perfevent_pmda%3A%20Add%20PMU%20events%20ex=
ported%20from%20kernel%20%23github">Reply To Sender</a>
|
<a target=3D"_blank" href=3D"https://groups.io/mt/4404698?uid=3D174580">=
Mute This Topic</a>
=20
| <a href=3D"https://groups.io/g/pcp/post">New Topic</a><br>
<a href=3D"https://groups.io/mk?hashtag=3Dgithub&subid=3D354243">Mute #git=
hub</a>
<p>
<p>pcp mailing list<br />[email protected]<br /><a href=3D"https://groups.io/g=
/pcp/messages" target=3D"_blank">https://groups.io/g/pcp/messages</a></p>
<a href=3D"https://groups.io/g/pcp/editsub?uid=3D174580">Change Your Subsc=
ription</a><br>
<a href=3D"https://groups.io/g/pcp">Group Home</a><br>
<a href=3D"mailto:[email protected]">Contact Group Owner</a><br>
<a href=3D"https://groups.io/static/tos">Terms Of Service</a><br>
<a href=3D"https://groups.io/g/pcp/leave/354243/563757577/xyzzy">Unsubscri=
be From This Group</a><br>
<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
--yabbadabbadoo--