[pcp:master] reported: Tidy up of Vagrantfile & Start of OSX Sierra base box #github

--yabbadabbadoo
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable



[pcp:master] New Comment on Pull Request #278 Tidy up of Vagrantfile & Star=
t of OSX Sierra base box ( https://github.com/performancecopilot/pcp/pull/2=
78 )
By ryandoyle ( https://github.com/ryandoyle ) :

A couple of things @tallpsmith - Vagrant is aborting for me when I run a v=
agrant status . I'm falling through to the elsif(!platformOkToUseOSX) condi=
tional. You probably want to use STDERR.puts for non-fatal errors. - A few =
stylistic things, Ruby convention is lower-case snake-case

I think the logic could be simplified to only inform the user that they ca=
n use the OSX box if they are actually on OSX.



--yabbadabbadoo
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable





[pcp:master] New Comment on Pull Request <a href=3D"https://github.com/per=
formancecopilot/pcp/pull/278">#278 Tidy up of Vagrantfile & Start of OSX Si=
erra base box</a><br>
By <a href=3D"https://github.com/ryandoyle">ryandoyle</a>:<p>
<p>A couple of things @tallpsmith
- Vagrant is aborting for me when I run a <code>vagrant status</code>. I'm=
 falling through to the <code>elsif(!platformOkToUseOSX)</code> conditional=
. You probably want to use <code>STDERR.puts</code> for non-fatal errors.
- A few stylistic things, Ruby convention is lower-case snake-case</p>

<p>I think the logic could be simplified to only inform the user that they=
 <em>can</em> use the OSX box if they are actually on OSX.</p>



<p>


<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>

You receive all messages sent to this group.


<p>

<a target=3D"_blank" href=3D"https://groups.io/g/pcp/message/15260">View/R=
eply Online (#15260)</a> |


  <a target=3D"_blank" href=3D"mailto:[email protected]?subject=3DRe:%20%5Bpcp=
%5D%20%5Bpcp%3Amaster%5D%20reported%3A%20Tidy%20up%20of%20Vagrantfile%20%26=
%20Start%20of%20OSX%20Sierra%20base%20box%20%23github">Reply To Group</a>
  
    | <a target=3D"_blank" href=3D"mailto:?subject=3DRe:%20%5Bpcp%5D%20%5B=
pcp%3Amaster%5D%20reported%3A%20Tidy%20up%20of%20Vagrantfile%20%26%20Start%=
20of%20OSX%20Sierra%20base%20box%20%23github">Reply To Sender</a>
  


|


  <a target=3D"_blank" href=3D"https://groups.io/mt/4427492?uid=3D174580">=
Mute This Topic</a>
=20
| <a href=3D"https://groups.io/g/pcp/post">New Topic</a><br>



<a href=3D"https://groups.io/mk?hashtag=3Dgithub&subid=3D354243">Mute #git=
hub</a>

<p>

<p>pcp mailing list<br />[email protected]<br /><a href=3D"https://groups.io/g=
/pcp/messages" target=3D"_blank">https://groups.io/g/pcp/messages</a></p>

<a href=3D"https://groups.io/g/pcp/editsub?uid=3D174580">Change Your Subsc=
ription</a><br>
<a href=3D"https://groups.io/g/pcp">Group Home</a><br>
<a href=3D"mailto:[email protected]">Contact Group Owner</a><br>
<a href=3D"https://groups.io/static/tos">Terms Of Service</a><br>
<a href=3D"https://groups.io/g/pcp/leave/354243/563757577/xyzzy">Unsubscri=
be From This Group</a><br>

<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>


--yabbadabbadoo--