| Newsgroups |
gmane.comp.sysutils.pcp |
| Message-ID |
<[email protected]> |
--yabbadabbadoo
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
[performancecopilot/speed] Pull request closed by suyash ( https://github.c=
om/suyash ) :
#41 Port Speed to Windows ( https://github.com/performancecopilot/speed/pu=
ll/41 )
This makes Speed compile and pass all tests on Windows.
The following chances were made:
* Use mmap-go instead of syscall in memorymappedwriter.go .
* Import path/filepath instead of path in multiple files to make path-rela=
ted functionality OS-independent.
* And this is something I discovered while working on this. On Unix, you c=
an call remove on a file that is still opened and have everything go smooth=
ly; the file gets deleted when all it's handles are closed. But on Windows,=
trying to remove a file that's still open results in a The process cannot =
access the file because it is being used by another process error. Hence, f=
ile handles need to be closed at two places in the code.
I also added the printing of an err message in a t.Errorf call which helpe=
d me while debugging the third issue.
---
2 New Commits:
[speed:master] By Saurav Sachidanand <[email protected]>:
19ac04353241 ( https://github.com/performancecopilot/speed/commit/19ac0435=
3241e3a6a500962686aa728e3e1f02b3 ) : Port Speed to Windows
Added: vendor/github.com/edsrzf/mmap-go/LICENSE ( https://github.com/perfo=
rmancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/LICENSE )
Added: vendor/github.com/edsrzf/mmap-go/README.md ( https://github.com/per=
formancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/README.m=
d )
Added: vendor/github.com/edsrzf/mmap-go/mmap.go ( https://github.com/perfo=
rmancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/mmap.go )
Added: vendor/github.com/edsrzf/mmap-go/mmap_unix.go ( https://github.com/=
performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/mmap_=
unix.go )
Added: vendor/github.com/edsrzf/mmap-go/mmap_windows.go ( https://github.c=
om/performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/mm=
ap_windows.go )
Added: vendor/github.com/edsrzf/mmap-go/msync_netbsd.go ( https://github.c=
om/performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/ms=
ync_netbsd.go )
Added: vendor/github.com/edsrzf/mmap-go/msync_unix.go ( https://github.com=
/performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/msyn=
c_unix.go )
Modified: bytewriter/memorymappedwriter.go ( https://github.com/performanc=
ecopilot/speed/blob/master/bytewriter/memorymappedwriter.go )
Modified: bytewriter/memorymappedwriter_test.go ( https://github.com/perfo=
rmancecopilot/speed/blob/master/bytewriter/memorymappedwriter_test.go )
Modified: client.go ( https://github.com/performancecopilot/speed/blob/mas=
ter/client.go )
Modified: client_test.go ( https://github.com/performancecopilot/speed/blo=
b/master/client_test.go )
Modified: config.go ( https://github.com/performancecopilot/speed/blob/mas=
ter/config.go )
Modified: vendor/vendor.json ( https://github.com/performancecopilot/speed=
/blob/master/vendor/vendor.json )
[speed:master] By Suyash <[email protected]>:
97dc47c8cb2f ( https://github.com/performancecopilot/speed/commit/97dc47c8=
cb2fe16d6f21b1bb857cc4f38a257031 ) : Merge pull request #41 from saurvs/mas=
ter Port Speed to Windows
Added: vendor/github.com/edsrzf/mmap-go/LICENSE ( https://github.com/perfo=
rmancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/LICENSE )
Added: vendor/github.com/edsrzf/mmap-go/README.md ( https://github.com/per=
formancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/README.m=
d )
Added: vendor/github.com/edsrzf/mmap-go/mmap.go ( https://github.com/perfo=
rmancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/mmap.go )
Added: vendor/github.com/edsrzf/mmap-go/mmap_unix.go ( https://github.com/=
performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/mmap_=
unix.go )
Added: vendor/github.com/edsrzf/mmap-go/mmap_windows.go ( https://github.c=
om/performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/mm=
ap_windows.go )
Added: vendor/github.com/edsrzf/mmap-go/msync_netbsd.go ( https://github.c=
om/performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/ms=
ync_netbsd.go )
Added: vendor/github.com/edsrzf/mmap-go/msync_unix.go ( https://github.com=
/performancecopilot/speed/blob/master/vendor/github.com/edsrzf/mmap-go/msyn=
c_unix.go )
Modified: bytewriter/memorymappedwriter.go ( https://github.com/performanc=
ecopilot/speed/blob/master/bytewriter/memorymappedwriter.go )
Modified: bytewriter/memorymappedwriter_test.go ( https://github.com/perfo=
rmancecopilot/speed/blob/master/bytewriter/memorymappedwriter_test.go )
Modified: client.go ( https://github.com/performancecopilot/speed/blob/mas=
ter/client.go )
Modified: client_test.go ( https://github.com/performancecopilot/speed/blo=
b/master/client_test.go )
Modified: config.go ( https://github.com/performancecopilot/speed/blob/mas=
ter/config.go )
Modified: vendor/vendor.json ( https://github.com/performancecopilot/speed=
/blob/master/vendor/vendor.json )
---
[speed:master] New Comment on Pull Request #41 Port Speed to Windows ( http=
s://github.com/performancecopilot/speed/pull/41 )
By suyash ( https://github.com/suyash ) :
Thanks
---
[speed:master] New Comment on Pull Request #38 Added pcp-mmvstatsd to READM=
E ( https://github.com/performancecopilot/speed/pull/38 )
By suyash ( https://github.com/suyash ) :
@natoscott I agree. Merging this for now, should probably track creating a=
daemon mode by creating an issue in the issue tracker.
---
[performancecopilot/speed] Pull request closed by suyash ( https://github.c=
om/suyash ) :
#38 Added pcp-mmvstatsd to README ( https://github.com/performancecopilot/=
speed/pull/38 )
If that makes any sense.
---
2 New Commits:
[speed:master] By Lukas Zapletal <[email protected]>:
681009d01620 ( https://github.com/performancecopilot/speed/commit/681009d0=
16202f1af76906470c157b0681083a38 ) : Added pcp-mmvstatsd to README
Modified: README.md ( https://github.com/performancecopilot/speed/blob/mas=
ter/README.md )
[speed:master] By Suyash <[email protected]>:
b8996a04acf7 ( https://github.com/performancecopilot/speed/commit/b8996a04=
acf74afd7183e64251641765dc42b45b ) : Merge pull request #38 from lzap/doco =
Added pcp-mmvstatsd to README
Modified: README.md ( https://github.com/performancecopilot/speed/blob/mas=
ter/README.md )
---
[speed:master] New Comment on Issue #37 github.com/performancecopilot/speed=
/bytewriter package does not compile on Windows. ( https://github.com/perfo=
rmancecopilot/speed/issues/37 )
By suyash ( https://github.com/suyash ) :
Fixed in #41
---
[speed:master] Issue #37 github.com/performancecopilot/speed/bytewriter pac=
kage does not compile on Windows. ( https://github.com/performancecopilot/s=
peed/issues/37 ) closed by ChrisHines ( https://github.com/ChrisHines ) .
---
[speed:master] New Comment on Issue #3 explore using golang supplemental sy=
s packages for MemoryMappedWriter ( https://github.com/performancecopilot/s=
peed/issues/3 )
By suyash ( https://github.com/suyash ) :
Fixed in #41
---
[speed:master] Issue #3 explore using golang supplemental sys packages for =
MemoryMappedWriter ( https://github.com/performancecopilot/speed/issues/3 )=
closed by suyash ( https://github.com/suyash ) .
--yabbadabbadoo
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
[performancecopilot/speed] Pull request closed by <a href=3D"https://githu=
b.com/suyash">suyash</a>:<p>
<a href=3D"https://github.com/performancecopilot/speed/pull/41">#41 Port S=
peed to Windows</a><br>
<p>This makes Speed compile and pass all tests on Windows.</p>
<p>The following chances were made:</p>
<ul>
<li>Use <code>mmap-go</code> instead of <code>syscall</code> in <code>memo=
rymappedwriter.go</code>.</li>
<li>Import <code>path/filepath</code> instead of <code>path</code> in mult=
iple files to make path-related functionality OS-independent.</li>
<li>And this is something I discovered while working on this. On Unix, you=
can call <code>remove</code> on a file that is still opened and have every=
thing go smoothly; the file gets deleted when all it's handles are closed. =
But on Windows, trying to remove a file that's still open results in a <cod=
e>The process cannot access the file because it is being used by another pr=
ocess</code> error. Hence, file handles need to be closed at two places in =
the code.</li>
</ul>
<p>I also added the printing of an <code>err</code> message in a <code>t.E=
rrorf</code> call which helped me while debugging the third issue.</p>
<p>
<hr><p>
2 New Commits:
<p>
[speed:master] By Saurav Sachidanand <[email protected]>:<=
br>
<a href=3D"https://github.com/performancecopilot/speed/commit/19ac04353241=
e3a6a500962686aa728e3e1f02b3">19ac04353241</a>: Port Speed to Windows<p>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/LICENSE">vendor/github.com/edsrzf/mmap-go/=
LICENSE</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/README.md">vendor/github.com/edsrzf/mmap-g=
o/README.md</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/mmap.go">vendor/github.com/edsrzf/mmap-go/=
mmap.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/mmap_unix.go">vendor/github.com/edsrzf/mma=
p-go/mmap_unix.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/mmap_windows.go">vendor/github.com/edsrzf/=
mmap-go/mmap_windows.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/msync_netbsd.go">vendor/github.com/edsrzf/=
mmap-go/msync_netbsd.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/msync_unix.go">vendor/github.com/edsrzf/mm=
ap-go/msync_unix.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/bytewriter/memorymappedwriter.go">bytewriter/memorymappedwriter.go</a><b=
r>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/bytewriter/memorymappedwriter_test.go">bytewriter/memorymappedwriter_tes=
t.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/client.go">client.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/client_test.go">client_test.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/config.go">config.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/vendor/vendor.json">vendor/vendor.json</a><br>
<p><hr>
<p>
[speed:master] By Suyash <[email protected]>:<br>
<a href=3D"https://github.com/performancecopilot/speed/commit/97dc47c8cb2f=
e16d6f21b1bb857cc4f38a257031">97dc47c8cb2f</a>: Merge pull request #41 from=
saurvs/master
Port Speed to Windows<p>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/LICENSE">vendor/github.com/edsrzf/mmap-go/=
LICENSE</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/README.md">vendor/github.com/edsrzf/mmap-g=
o/README.md</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/mmap.go">vendor/github.com/edsrzf/mmap-go/=
mmap.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/mmap_unix.go">vendor/github.com/edsrzf/mma=
p-go/mmap_unix.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/mmap_windows.go">vendor/github.com/edsrzf/=
mmap-go/mmap_windows.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/msync_netbsd.go">vendor/github.com/edsrzf/=
mmap-go/msync_netbsd.go</a><br>
Added: <a href=3D"https://github.com/performancecopilot/speed/blob/master/=
vendor/github.com/edsrzf/mmap-go/msync_unix.go">vendor/github.com/edsrzf/mm=
ap-go/msync_unix.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/bytewriter/memorymappedwriter.go">bytewriter/memorymappedwriter.go</a><b=
r>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/bytewriter/memorymappedwriter_test.go">bytewriter/memorymappedwriter_tes=
t.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/client.go">client.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/client_test.go">client_test.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/config.go">config.go</a><br>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/vendor/vendor.json">vendor/vendor.json</a><br>
<p>
<hr><p>
[speed:master] New Comment on Pull Request <a href=3D"https://github.com/p=
erformancecopilot/speed/pull/41">#41 Port Speed to Windows</a><br>
By <a href=3D"https://github.com/suyash">suyash</a>:<p>
<p>Thanks</p>
<p>
<hr><p>
[speed:master] New Comment on Pull Request <a href=3D"https://github.com/p=
erformancecopilot/speed/pull/38">#38 Added pcp-mmvstatsd to README</a><br>
By <a href=3D"https://github.com/suyash">suyash</a>:<p>
<p>@natoscott I agree. Merging this for now, should probably track creatin=
g a daemon mode by creating an issue in the issue tracker.</p>
<p>
<hr><p>
[performancecopilot/speed] Pull request closed by <a href=3D"https://githu=
b.com/suyash">suyash</a>:<p>
<a href=3D"https://github.com/performancecopilot/speed/pull/38">#38 Added =
pcp-mmvstatsd to README</a><br>
<p>If that makes any sense.</p>
<p>
<hr><p>
2 New Commits:
<p>
[speed:master] By Lukas Zapletal <[email protected]>:<br>
<a href=3D"https://github.com/performancecopilot/speed/commit/681009d01620=
2f1af76906470c157b0681083a38">681009d01620</a>: Added pcp-mmvstatsd to READ=
ME<p>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/README.md">README.md</a><br>
<p><hr>
<p>
[speed:master] By Suyash <[email protected]>:<br>
<a href=3D"https://github.com/performancecopilot/speed/commit/b8996a04acf7=
4afd7183e64251641765dc42b45b">b8996a04acf7</a>: Merge pull request #38 from=
lzap/doco
Added pcp-mmvstatsd to README<p>
Modified: <a href=3D"https://github.com/performancecopilot/speed/blob/mast=
er/README.md">README.md</a><br>
<p>
<hr><p>
[speed:master] New Comment on Issue <a href=3D"https://github.com/performa=
ncecopilot/speed/issues/37">#37 github.com/performancecopilot/speed/bytewri=
ter package does not compile on Windows.</a><br>
By <a href=3D"https://github.com/suyash">suyash</a>:<p>
<p>Fixed in #41</p>
<p>
<hr><p>
[speed:master] Issue <a href=3D"https://github.com/performancecopilot/spee=
d/issues/37">#37 github.com/performancecopilot/speed/bytewriter package doe=
s not compile on Windows.</a> closed by <a href=3D"https://github.com/Chris=
Hines">ChrisHines</a>.
<p>
<hr><p>
[speed:master] New Comment on Issue <a href=3D"https://github.com/performa=
ncecopilot/speed/issues/3">#3 explore using golang supplemental sys package=
s for MemoryMappedWriter</a><br>
By <a href=3D"https://github.com/suyash">suyash</a>:<p>
<p>Fixed in #41</p>
<p>
<hr><p>
[speed:master] Issue <a href=3D"https://github.com/performancecopilot/spee=
d/issues/3">#3 explore using golang supplemental sys packages for MemoryMap=
pedWriter</a> closed by <a href=3D"https://github.com/suyash">suyash</a>.
<p>
<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>
You receive all messages sent to this group.
<p>
<a target=3D"_blank" href=3D"https://groups.io/g/pcp/message/15340">View/R=
eply Online (#15340)</a> |
<a target=3D"_blank" href=3D"mailto:[email protected]?subject=3DRe:%20%5Bpcp=
%5D%20Updates%20to%20Github%20%23github%20%23golang">Reply To Group</a>
| <a target=3D"_blank" href=3D"mailto:?subject=3DRe:%20%5Bpcp%5D%20Upd=
ates%20to%20Github%20%23github%20%23golang">Reply To Sender</a>
|
<a target=3D"_blank" href=3D"https://groups.io/mt/4437126?uid=3D174580">=
Mute This Topic</a>
=20
| <a href=3D"https://groups.io/g/pcp/post">New Topic</a><br>
<a href=3D"https://groups.io/mk?hashtag=3Dgithub&subid=3D354243">Mute #git=
hub</a>
|
<a href=3D"https://groups.io/mk?hashtag=3Dgolang&subid=3D354243">Mute #gol=
ang</a>
<p>
<p>pcp mailing list<br />[email protected]<br /><a href=3D"https://groups.io/g=
/pcp/messages" target=3D"_blank">https://groups.io/g/pcp/messages</a></p>
<a href=3D"https://groups.io/g/pcp/editsub?uid=3D174580">Change Your Subsc=
ription</a><br>
<a href=3D"https://groups.io/g/pcp">Group Home</a><br>
<a href=3D"mailto:[email protected]">Contact Group Owner</a><br>
<a href=3D"https://groups.io/static/tos">Terms Of Service</a><br>
<a href=3D"https://groups.io/g/pcp/leave/354243/563757577/xyzzy">Unsubscri=
be From This Group</a><br>
<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
--yabbadabbadoo--