Re: Bug fix (not sure how to submit)

Brian Postow wrote:

> We had a problem dealing with a buggy FOIP box that would get the T30 frame, checked the CRC, found that it was correct, and then turned it into T38 packets and sent them to our computer. However there were two problems: 1) the FOIP box lost packets. and 2) T38 doesn't pass the CRC, it just says "yup, the CRC was correct on this end" and so, Hylafax got a short frame, which ends up with a broken TIFF file.
> 
> We fixed this problem in faxd/Class1Recv.c++ by in additon to checking the CRC, checking the frame length:
> 
> In faxd/Class1Recv.c++, in recvPageECMData line 1373
> 	if (frame.checkCRC()) 
>     becomes
>         if (frame.checkCRC()  && frame.getLength() == frameSize+6) 
> 
> This is in the 6.0.4 version... 
> 
> Is there an official way I'm supposed to submit this?

You could have submitted the bug and patch through bugzilla at 
http://bugs.hylafax.org/, but a mail to -devel is sometimes enough. I 
will look at this fix.

Thanks,

-- 
Patrice Fournier
iFAX Solutions, Inc.
http://www.ifax.com/


____________________ HylaFAX(tm) Developers Mailing List ____________________
  To subscribe/unsubscribe, click http://lists.hylafax.org/cgi-bin/lsg2.cgi
On UNIX: mail -s unsubscribe [email protected] < /dev/null