[Bug 957] Clients can not login

http://bugs.hylafax.org/show_bug.cgi?id=957





------- Comment #4 from [email protected]  2014-07-31 09:41 -------
The actual non-verification of NULL returned from crypt for that function
origins from before the code was tracked by CVS. It's been moved around and
other checks have been added/moved around it, but the strcmp of the return of
crypt has been checked for over 15 years:

^935bf36 (root             1998-10-12 20:47:47 +0000 121)     if (pass[0] ==
'\0' || strcmp(crypt(pass, passwd), passwd) != 0) {

Not that I'm against checking the result of crypt, but I'm wondering what you
pass to crypt for it to fail like that when nobody else had that issue in over
15 years? We know pass is not null because it was checked in checkPasswd(). We
know passwd is not empty because it was checked in userCmd(). So what are they?


-- 
Configure bugmail: http://bugs.hylafax.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


____________________ HylaFAX(tm) Developers Mailing List ____________________
  To subscribe/unsubscribe, click http://lists.hylafax.org/cgi-bin/lsg2.cgi
On UNIX: mail -s unsubscribe [email protected] < /dev/null