Re: NOTIFY_FAXMASTER=errors|"errors"|error does not seem to work

This has been a long-standing issue in the hylafax.org releases ever 
since v4.3.1 (2006) was released where NOTIFY_FAXMASTER support was 
apparently inadvertently removed altogether in a rewrite of many parts 
of the notify script to accommodate templating.

NOTIFY_FAXMASTER support was reintroduced in v6.0.0 (2009), but the 
"errors:success" mistake has been there ever since.  Yes, it should read 
"errors:done".  It seems like this bug has been reported on multiple 
occasions before in the last 7 years, but I could be wrong.

Hopefully somebody will take note of this report and will see it fixed 
in the code repository for an eventual v6.0.7 release, but mind-you, the 
v6.0.6 release was 4 years ago.  I suspect that many just switch to 
using HylaFAX+ rather than waiting for hylafax.org releases.

Thanks,

Lee.


On 06/05/2016 05:23 AM, Matthias Stadelmeyer wrote:
> Mona Meyer <meymona <at> gmail.com <http://gmail.com>> writes:
>
> > My File /etc/hylafax/FaxNotify has three lines:
> > RETURNFILETYPE=pdf
> > TEMPLATE=de
> > NOTIFY_FAXMASTER=errors
> >
> > The first two lines are obviously working: After sending a fax, the user
> > gets an email in german with the faxed document attached as pdf.
> >
> > No, no matter which user sends a fax, there are always _two_ emails 
> sent:
> > One in german to the sending user, and another in english to the 
> FaxMaster.
> >
>
> I think there is indeed something wrong with the script.
>
> After a job is successfully submitted, syslog shows the script "notify"
> executed as follows:
>
> NOTIFY: bin/notify "doneq/q17" "done" "0:00:46"
>
> In /var/spool/hylafax/bin/notify "WHY" is therefore set to "done":
> line 55: WHY=$2
>
> But to avoid a second message to faxmaster in case of a success "WHY" 
> should
> have been set to "success":
>
> case "$NOTIFY_FAXMASTER:$WHY" in
>     "always:"*)                     do_faxmaster;;
>     "yes:"*)                        do_faxmaster;;
>
>     "errors:success")               ;;              # Not errors
>     "errors:blocked")               ;;              # Not errors
>     "errors:"*)                     do_faxmaster;;  # errors
>
>     *)                              ;;              # Do nothing;
> esac
>
> So it seems that you hust have to change "errors:success" to 
> "errors:done".
> But who knows wheter someting else depends on the origin setting.