Re: Asterisk bridging framework

"Joshua C. Colp" <[email protected]> Sun, 31 Dec 2023 14:43:48 -0400
Newsgroups gmane.comp.telephony.pbx.asterisk.devel
Message-ID <CAM0A2Z1KbSopZZ2MaJn4OJUbDeEQ3u3-4me=H3q28ymhXpRutw@mail.gmail.com>
--===============7810475894226824227==
Content-Type: multipart/alternative; boundary="000000000000071cac060dd2a60a"

--000000000000071cac060dd2a60a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 31, 2023 at 11:37=E2=80=AFAM <[email protected]> wrote:

>
> Thanks, Josh,
>    One other question I have: is there any current mechanism for
> retaining a channel's TX audio in the RX audio it gets from the bridge?
> I see in bridge_softmix that the channel's audio is removed, but at
> least here I don't see any logic to keep the audio:
>
> https://github.com/asterisk/asterisk/blob/master/bridges/bridge_softmix.c=
#L199
>
> I thought maybe this was related to the binaural setting, but now I
> don't think so since both paths subtract.
> Interface wise, this is more about the bridging framework as a whole,
> but practically speaking, only bridge_softmix is used as the bridging
> technology, so I'm more focused on that.
>
> If the answer is 'no', I'm assuming a bridging option would need to be
> added to not subtract the sender's audio from what it gets back from the
> bridge? If this was done, would it be fine if only certain technologies,
> e.g. bridge_softmix obeyed this? Or does it have to be universally
> implemented?


There is no current mechanism, because it's counter to how almost everyone
expects/needs bridging to work and operate. Hearing yourself never ends
well. Why is such a thing needed? Does it have wide applicability? Is it
only for your usage/use case?

--=20
Joshua C. Colp
Director of Engineering | Asterisk Project Lead
Sangoma Technologies
Check us out at www.sangoma.com and www.asterisk.org

--000000000000071cac060dd2a60a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sun, Dec 31, 2023 at 11:37=E2=80=AFAM =
&lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt=
; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex"><br>
Thanks, Josh,<br>
=C2=A0=C2=A0 One other question I have: is there any current mechanism for =
<br>
retaining a channel&#39;s TX audio in the RX audio it gets from the bridge?=
<br>
I see in bridge_softmix that the channel&#39;s audio is removed, but at <br=
>
least here I don&#39;t see any logic to keep the audio: <br>
<a href=3D"https://github.com/asterisk/asterisk/blob/master/bridges/bridge_=
softmix.c#L199" rel=3D"noreferrer" target=3D"_blank">https://github.com/ast=
erisk/asterisk/blob/master/bridges/bridge_softmix.c#L199</a><br>
<br>
I thought maybe this was related to the binaural setting, but now I <br>
don&#39;t think so since both paths subtract.<br>
Interface wise, this is more about the bridging framework as a whole, <br>
but practically speaking, only bridge_softmix is used as the bridging <br>
technology, so I&#39;m more focused on that.<br>
<br>
If the answer is &#39;no&#39;, I&#39;m assuming a bridging option would nee=
d to be <br>
added to not subtract the sender&#39;s audio from what it gets back from th=
e <br>
bridge? If this was done, would it be fine if only certain technologies, <b=
r>
e.g. bridge_softmix obeyed this? Or does it have to be universally <br>
implemented?</blockquote><div><br></div><div>There is no current mechanism,=
 because it&#39;s counter to how almost everyone expects/needs bridging to =
work and operate. Hearing yourself never ends well. Why is such a thing nee=
ded? Does it have wide applicability? Is it only for your usage/use case?</=
div></div><div><br></div><span class=3D"gmail_signature_prefix">-- </span><=
br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div di=
r=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=
=3D"ltr"><div style=3D"font-family:tahoma,sans-serif"><font color=3D"#07376=
3">Joshua C. Colp</font></div><div style=3D"font-family:tahoma,sans-serif">=
<font color=3D"#073763">Director of Engineering | Asterisk Project Lead</fo=
nt></div><div style=3D"font-family:tahoma,sans-serif"><font color=3D"#07376=
3">Sangoma Technologies</font></div><div style=3D"font-family:tahoma,sans-s=
erif"><font color=3D"#073763">Check us out at <a href=3D"http://www.sangoma=
.com" target=3D"_blank">www.sangoma.com</a> and <a href=3D"http://www.aster=
isk.org" target=3D"_blank">www.asterisk.org</a></font><br></div></div></div=
></div></div></div></div></div></div></div></div>

--000000000000071cac060dd2a60a--


--===============7810475894226824227==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

LS0gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fXwotLSBCYW5kd2lkdGggYW5kIENvbG9jYXRpb24gUHJvdmlkZWQgYnkg
aHR0cDovL3d3dy5hcGktZGlnaXRhbC5jb20gLS0KCmFzdGVyaXNrLWRldiBtYWlsaW5nIGxpc3QK
VG8gVU5TVUJTQ1JJQkUgb3IgdXBkYXRlIG9wdGlvbnMgdmlzaXQ6CiAgIGh0dHA6Ly9saXN0cy5k
aWdpdW0uY29tL21haWxtYW4vbGlzdGluZm8vYXN0ZXJpc2stZGV2

--===============7810475894226824227==--