Re: Finding old patches

--===============7594392921830627274==
Content-Type: multipart/alternative; boundary="000000000000bfde1d060a992396"

--000000000000bfde1d060a992396
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 20, 2023 at 1:45=E2=80=AFPM Dovid Bender <[email protected]> =
wrote:

> Hi,
>
> In the past when I wanted to back port a patch I would go on to the issue
> tracker and find a link to the patches that were uploaded ( I think
> through gerrit?). I am trying to see what changes were done for
> https://issues-archive.asterisk.org/ASTERISK-26109. It seems the code
> changes were introduced in 14.4.0-rc1. Is there any "n00b" way of seeing
> what patches were created for this specific issue?
>

The git commit history can be used, the commit message can be grepped,
example:

=E2=9C=94 jcolp@kappa:~/development/asterisk/github [21| =E2=80=A62=E2=9A=
=91 3]> git log | grep -B4
"OpenSSL 1.1.0 support"
Merge: a0c0b1c9cb 26c8552fff
Author: zuul <[email protected]>
Date:   Wed Nov 30 23:26:46 2016 -0600

    Merge "OpenSSL 1.1.0 support"
--
commit 26c8552fff499419bdf12b663e76ecfc408b3085
Author: Tzafrir Cohen <[email protected]>
Date:   Tue Jun 28 23:26:59 2016 +0200

    OpenSSL 1.1.0 support

So the commit is "26c8552fff499419bdf12b663e76ecfc408b3085" and you can use
git show to display that commit, which includes the changes including in
diff format:

=E2=9C=94 jcolp@kappa:~/development/asterisk/github [21| =E2=80=A62=E2=9A=
=91 3]> git show 26c8552fff
commit 26c8552fff499419bdf12b663e76ecfc408b3085
Author: Tzafrir Cohen <[email protected]>
Date:   Tue Jun 28 23:26:59 2016 +0200

    OpenSSL 1.1.0 support

    OpenSSL 1.1.0 includes some major changes in the interface. See
    https://wiki.openssl.org/index.php/1.1_API_Changes .

    Status: Right now there are still a few deprecation notes with OpenSSL
    1.1.0. But it's a start.

    Changes:
    * CRYPTO_LOCK is no longer available. Replace it with its value for now=
.
      I don't completely understand what it is used for there.
    * Remove several functions from libasteriskssl that seem to no longer b=
e
      needed.
    * Structures have become opaque and are accesses with accessors.
    * ERR_remove_thread_state() no longer needed.
    * SSLv2 code now could no longer be used in 1.1.

    ASTERISK-26109 #close

    Change-Id: I5e29d477d486ca29b6aae0dc2f5dff960c1cb82b

diff --git a/main/iostream.c b/main/iostream.c

The same goes for the rest of the associated commits on the linked issue.

--=20
Joshua C. Colp
Asterisk Project Lead
Sangoma Technologies
Check us out at www.sangoma.com and www.asterisk.org

--000000000000bfde1d060a992396
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Nov 20, 2023 at 1:45=E2=80=AFPM D=
ovid Bender &lt;<a href=3D"mailto:[email protected]">[email protected]<=
/a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"ltr">Hi,<br><div><br></div><div>In=C2=
=A0the past when I wanted to back port a patch I would go on to the issue t=
racker and find a link to the=C2=A0patches that were uploaded ( I think thr=
ough=C2=A0gerrit?). I am trying to see what changes were done for=C2=A0<a h=
ref=3D"https://issues-archive.asterisk.org/ASTERISK-26109" target=3D"_blank=
">https://issues-archive.asterisk.org/ASTERISK-26109</a>. It seems the code=
 changes were introduced in 14.4.0-rc1. Is there any &quot;n00b&quot; way o=
f seeing what patches were created for this specific issue?<br></div></div>=
</blockquote><div><br></div><div>The git commit history can be used, the co=
mmit message can be grepped, example:=C2=A0</div><div><br></div>=E2=9C=94 j=
colp@kappa:~/development/asterisk/github [21| =E2=80=A62=E2=9A=91 3]&gt; gi=
t log | grep -B4 &quot;OpenSSL 1.1.0 support&quot;<br>Merge: a0c0b1c9cb 26c=
8552fff<br>Author: zuul &lt;<a href=3D"mailto:[email protected]">zuu=
[email protected]</a>&gt;<br>Date: =C2=A0 Wed Nov 30 23:26:46 2016 -060=
0<br><br>=C2=A0 =C2=A0 Merge &quot;OpenSSL 1.1.0 support&quot;<br>--<br>com=
mit 26c8552fff499419bdf12b663e76ecfc408b3085<br>Author: Tzafrir Cohen &lt;<=
a href=3D"mailto:[email protected]">[email protected]</a>&gt;=
<br>Date: =C2=A0 Tue Jun 28 23:26:59 2016 +0200<br><br>=C2=A0 =C2=A0 OpenSS=
L 1.1.0 support</div><div class=3D"gmail_quote"><br></div><div class=3D"gma=
il_quote">So the commit is &quot;26c8552fff499419bdf12b663e76ecfc408b3085&q=
uot; and you can use git show to display that commit, which includes the ch=
anges including in diff format:</div><div class=3D"gmail_quote"><br>=E2=9C=
=94 jcolp@kappa:~/development/asterisk/github [21| =E2=80=A62=E2=9A=91 3]&g=
t; git show 26c8552fff<br>commit 26c8552fff499419bdf12b663e76ecfc408b3085<b=
r>Author: Tzafrir Cohen &lt;<a href=3D"mailto:[email protected]">tza=
[email protected]</a>&gt;<br>Date: =C2=A0 Tue Jun 28 23:26:59 2016 +020=
0<br><br>=C2=A0 =C2=A0 OpenSSL 1.1.0 support<br>=C2=A0 =C2=A0 <br>=C2=A0 =
=C2=A0 OpenSSL 1.1.0 includes some major changes in the interface. See<br>=
=C2=A0 =C2=A0 <a href=3D"https://wiki.openssl.org/index.php/1.1_API_Changes=
">https://wiki.openssl.org/index.php/1.1_API_Changes</a> .<br>=C2=A0 =C2=A0=
 <br>=C2=A0 =C2=A0 Status: Right now there are still a few deprecation note=
s with OpenSSL<br>=C2=A0 =C2=A0 1.1.0. But it&#39;s a start.<br>=C2=A0 =C2=
=A0 <br>=C2=A0 =C2=A0 Changes:<br>=C2=A0 =C2=A0 * CRYPTO_LOCK is no longer =
available. Replace it with its value for now.<br>=C2=A0 =C2=A0 =C2=A0 I don=
&#39;t completely understand what it is used for there.<br>=C2=A0 =C2=A0 * =
Remove several functions from libasteriskssl that seem to no longer be<br>=
=C2=A0 =C2=A0 =C2=A0 needed.<br>=C2=A0 =C2=A0 * Structures have become opaq=
ue and are accesses with accessors.<br>=C2=A0 =C2=A0 * ERR_remove_thread_st=
ate() no longer needed.<br>=C2=A0 =C2=A0 * SSLv2 code now could no longer b=
e used in 1.1.<br>=C2=A0 =C2=A0 <br>=C2=A0 =C2=A0 ASTERISK-26109 #close<br>=
=C2=A0 =C2=A0 <br>=C2=A0 =C2=A0 Change-Id: I5e29d477d486ca29b6aae0dc2f5dff9=
60c1cb82b<br><br>diff --git a/main/iostream.c b/main/iostream.c</div><div c=
lass=3D"gmail_quote"><br></div><div class=3D"gmail_quote">The same goes for=
 the rest of the associated commits on the linked issue.</div><div><br></di=
v><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" cla=
ss=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=
=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"f=
ont-family:tahoma,sans-serif"><font color=3D"#073763">Joshua C. Colp</font>=
</div><div style=3D"font-family:tahoma,sans-serif"><font color=3D"#073763">=
Asterisk Project Lead</font></div><div style=3D"font-family:tahoma,sans-ser=
if"><font color=3D"#073763">Sangoma Technologies</font></div><div style=3D"=
font-family:tahoma,sans-serif"><font color=3D"#073763">Check us out at <a h=
ref=3D"http://www.sangoma.com" target=3D"_blank">www.sangoma.com</a> and <a=
 href=3D"http://www.asterisk.org" target=3D"_blank">www.asterisk.org</a></f=
ont><br></div></div></div></div></div></div></div></div></div></div></div>

--000000000000bfde1d060a992396--


--===============7594392921830627274==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

LS0gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fXwotLSBCYW5kd2lkdGggYW5kIENvbG9jYXRpb24gUHJvdmlkZWQgYnkg
aHR0cDovL3d3dy5hcGktZGlnaXRhbC5jb20gLS0KCkNoZWNrIG91dCB0aGUgbmV3IEFzdGVyaXNr
IGNvbW11bml0eSBmb3J1bSBhdDogaHR0cHM6Ly9jb21tdW5pdHkuYXN0ZXJpc2sub3JnLwoKTmV3
IHRvIEFzdGVyaXNrPyBTdGFydCBoZXJlOgogICAgICBodHRwczovL3dpa2kuYXN0ZXJpc2sub3Jn
L3dpa2kvZGlzcGxheS9BU1QvR2V0dGluZytTdGFydGVkCgphc3Rlcmlzay11c2VycyBtYWlsaW5n
IGxpc3QKVG8gVU5TVUJTQ1JJQkUgb3IgdXBkYXRlIG9wdGlvbnMgdmlzaXQ6CiAgIGh0dHA6Ly9s
aXN0cy5kaWdpdW0uY29tL21haWxtYW4vbGlzdGluZm8vYXN0ZXJpc2stdXNlcnM=

--===============7594392921830627274==--