patch preventing creation of empty top file (was Re: doc patch

Peter Moulder <[email protected]> Sat, 15 Sep 2001 03:35:09 +1000
Newsgroups gmane.comp.tex.texi2html.devel
Message-ID <[email protected]> 
[Apologies to Karl-Heinz,Adrian if you didn't want -dev messages.
 Won't cc you for future messages.]

On Fri, Sep 14, 2001 at 12:38:39PM -0400, Derek Robert Price wrote:

> You actually have commit privileges to the source yourself

I got two replies, one saying they were granted and a later message saying 
they weren't granted.  (I'm not fussed either way.)

> 1) Submit the patch to the dev list for comments.  (Another list can split for
>    patches if it ever seems desirable).
> 2) Others comment / recommend revisions.
> 3) If necessary, author revises patch and resubmits - return to step 2.
> 4) Author commits patch if (s)he has privileges - else someone else commits.

Sounds good.

Attached is a short context diff as per subject line.  (See also
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=101265&repeatmerged=yes>.)

pjm.
toppatch (text/plain, 1.8 KB) 
Index: texi2html.pl
===================================================================
RCS file: /usr/local/tigris/data/helm/cvs/repository/texi2html/texi2html.pl,v
retrieving revision 1.3
diff -d -c -r1.3 texi2html.pl
*** texi2html.pl	2001/05/01 21:33:44	1.3
--- texi2html.pl	2001/09/14 17:17:15
***************
*** 3677,3696 ****
      #############################################################################
      # print Top
      #
!     open(FILE, "> $docu_top_file")
!         || die "$ERROR: Can't open $docu_top_file for writing: $!\n";
!     &$T2H_print_page_head(\*FILE) unless ($T2H_SPLIT);
! 
!     if ($has_top)
      {
!         print "# Creating Top in $docu_top_file ...\n" if $T2H_VERBOSE;
!         $T2H_THIS_SECTION = $T2H_TOP;
!         $T2H_HREF{This} = $T2H_HREF{Top};
!         $T2H_NAME{This} = $T2H_NAME{Top};
!         &$T2H_print_Top(\*FILE);
!     }
  
!     close(FILE) if $T2H_SPLIT;
  
      #############################################################################
      # Print sections
--- 3677,3699 ----
      #############################################################################
      # print Top
      #
!     if ($has_top || !$T2H_SPLIT)
      {
!         open(FILE, "> $docu_top_file")
!             || die "$ERROR: Can't open $docu_top_file for writing: $!\n";
!         &$T2H_print_page_head(\*FILE) unless ($T2H_SPLIT);
  
!         if ($has_top)
!         {
!             print "# Creating Top in $docu_top_file ...\n" if $T2H_VERBOSE;
!             $T2H_THIS_SECTION = $T2H_TOP;
!             $T2H_HREF{This} = $T2H_HREF{Top};
!             $T2H_NAME{This} = $T2H_NAME{Top};
!             &$T2H_print_Top(\*FILE);
!         }
! 
! 	close(FILE) if $T2H_SPLIT;
!     }
  
      #############################################################################
      # Print sections