Re: local, cvs messages bouncing, should I coninue asking ?

>>>>> "Dumas" == Dumas Patrice <[email protected]> writes:

    Dumas> Hi,

    Dumas> The cvs commit messages are bouncing to me. I don't know
    Dumas> what to do with that.

Can you please say more about these bounces?

    Dumas> There are some local in the code which should be my, like
    Dumas> (an example, there are many more) : sub incr_sec_num

    Dumas> Is there specific reason ? (My rememberance was that local
    Dumas> was only needed for stuff which has to be global like $_).

Pat, I have done a lot in this area and found quite a few bugs that way.

I recommend using a good set of regression tests and then go ahead and
convert all unnecessarily dynamically bound variables to lexicals.

Global variables could also become lexicals on the global level, I
think.

    Dumas> And lastly is there somebody reviewing what happens to the
    Dumas> code or should I just do whatever I want ? In the one hand
    Dumas> I would like to stop asking on the list and just do things
    Dumas> I propose, but on the other hand I don't want to make
    Dumas> changes to the code that the one who made/maintain it
    Dumas> dislike, as, with write access to the cvs I can so
    Dumas> anything.

Depends whether you really want to be on your own and what the project
owner has to say.

The "many eyes" principle has proven to be quite successful for many
projects.

I'd say keep proposing changes, do them, test them, commit them, and
fix the new bugs ;->

Best regards,

Adrian

    Dumas> Pat

    Dumas> ---------------------------------------------------------------------
    Dumas> To unsubscribe, e-mail: [email protected]
    Dumas> For additional commands, e-mail: [email protected]

-- 
Adrian Aichner
 mailto:[email protected]
 http://www.xemacs.org/