Re: config.h outdated

On Sun, Jan 18, 2026 at 03:16:10PM +0100, Patrice Dumas wrote:
> On Sun, Jan 18, 2026 at 01:00:01PM +0000, Gavin Smith wrote:
> > On Sun, Jan 18, 2026 at 01:37:40PM +0100, Patrice Dumas wrote:
> > > I think that in tta/C/Makefile.am, the following line was there to find
> > > config.h:
> > > 
> > >   AM_CPPFLAGS = -I$(srcdir)
> > > 
> > > 
> > > I had a look at the build flags to understand how config.h was found,
> > > and I think that it is because in DEFAULT_INCLUDES there is
> > > -I$(top_builddir).  I do not know if it is something we should rely on,
> > > in which case we could replace by
> > > 
> > >   AM_CPPFLAGS =
> > > 
> > > or if we want to to add ourselves, like
> > > 
> > >   AM_CPPFLAGS = -I$(srcdir)/..
> > 
> > It works perfectly well, so it is not something that we need to mess with.
> > As AC_CONFIG_HEADERS is given in configure.ac at the top-level, it would
> > be expected that config.h would be accessible in subdirectories without
> > any further changes being needed.
> 
> Further changes from us in Makefile.am?  Previously, we needed to add it
> because it was not in top_srcdir.

OK, I hadn't realised that.