Re: error: 'unitypes.h' file not found

On Mon, Feb 02, 2026 at 06:37:14PM +0000, Gavin Smith wrote:
> On Mon, Feb 02, 2026 at 02:02:32PM +0100, Bruno Haible via Bug reports for the GNU Texinfo documentation system wrote:
> > Hi,
> > 
> > The weekly CI, this week, fails on macOS 26. (Last week, the same build was OK.)
> > 
> > Making all in XSTexinfo
> > /bin/sh ../../libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I../../../../tta/perl/XSTexinfo -I../..  -I../../../../tta/perl/XSTexinfo/../../C/main -I../../../../tta/perl/XSTexinfo -I../../../../tta/perl/XSTexinfo/../../C -I../../../../tta/gnulib/lib -I../../gnulib/lib -I/opt/homebrew/opt/gettext/include -Wall -fno-common -DPERL_DARWIN -DNO_THREAD_SAFE_QUERYLOCALE -DNO_POSIX_2008_LOCALE -DHAS_BROKEN_LANGINFO_CODESET -DNO_LOCALE_COLLATE -fno-strict-aliasing -pipe -fstack-protector-strong    -MT libparagraph_la-xspara.lo -MD -MP -MF .deps/libparagraph_la-xspara.Tpo -c -o libparagraph_la-xspara.lo `test -f 'xspara.c' || echo '../../../../tta/perl/XSTexinfo/'`xspara.c
> > libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../../../../tta/perl/XSTexinfo -I../.. -I../../../../tta/perl/XSTexinfo/../../C/main -I../../../../tta/perl/XSTexinfo -I../../../../tta/perl/XSTexinfo/../../C -I../../../../tta/gnulib/lib -I../../gnulib/lib -I/opt/homebrew/opt/gettext/include -Wall -fno-common -DPERL_DARWIN -DNO_THREAD_SAFE_QUERYLOCALE -DNO_POSIX_2008_LOCALE -DHAS_BROKEN_LANGINFO_CODESET -DNO_LOCALE_COLLATE -fno-strict-aliasing -pipe -fstack-protector-strong -MT libparagraph_la-xspara.lo -MD -MP -MF .deps/libparagraph_la-xspara.Tpo -c ../../../../tta/perl/XSTexinfo/xspara.c  -fno-common -DPIC -o .libs/libparagraph_la-xspara.o
> > ../../../../tta/perl/XSTexinfo/xspara.c:25:10: fatal error: 'unitypes.h' file not found
> >    25 | #include <unitypes.h>
> >       |          ^~~~~~~~~~~~
> > 1 error generated.
> > make[5]: *** [libparagraph_la-xspara.lo] Error 1
> > 
> > This suggests some missing -I option...
> > 
> > Bruno
> > 
> > 

I think that the problem is that if enable_xs is yes, the XSParagraph
code requires Gnulib being built, but if BUILD_C_CODE is no it is not
built since the commit 05bcc5cf10e, which lead to, in tta/Makefile.am:

-SUBDIRS = gnulib/lib
+SUBDIRS =
+
+if BUILD_C_CODE
+SUBDIRS += gnulib/lib
+endif

> My biggest suspicion is the various changes to Makefile.am and
> configure.ac files regarding the HAVE_ICONV conditional and whether
> C libraries are built, e.g. commit 5de817edcbf580f (2026-02-01) and
> 05bcc5cf10eefd5d68 (2026-01-29).

This is the commit just above.

> I notice in tta/perl/XSTexinfo/Makefile.am, XSParagraph.la and MiscXS.la
> are anomalous in not being contained within an "if BUILD_C_CODE" conditional.

It is not anomalous, "if BUILD_C_CODE" is only needed for the XS modules
that require the C libraries, XSParagraph.la and MiscXS.la do not.

I propose to change to the following:

SUBDIRS =

if BUILD_C_CODE
SUBDIRS += gnulib/lib
else
if ! DISABLE_XS
SUBDIRS += gnulib/lib
endif
endif

-- 
Pat