Re: texinfo-7.2.92 pretest available [segfault building gcc docs]

On Wed, Feb 25, 2026 at 10:31:29PM +0100, Patrice Dumas wrote:
> On Wed, Feb 25, 2026 at 08:26:41PM +0000, Gavin Smith wrote:
> > I'd hoped that one day we could remove the @definfoenclose command from Texinfo,
> > as it adds a lot of complexity to allow definining new Texinfo commands, for
> > no real benefit.  But if it's baked into the documentation for old gcc releases,
> > this could be a problem, in case somebody was wanting to use Texinfo to build
> > this older documentation.
> > 
> > Evidently the HTML output code does not cope well with a @definfoenclose-defined
> > command on a @subsection line.
> 
> The backtrace shows that in main/node_name_normalization.c, there is
> if (command_normalization_text[e->e.c->cmd])
> 
> This will fail for any user-defined command, including definfoenclose'd
> commands, but not only, also added index commands, or macro-defined
> commands (which are unlikely to appear here, though).
> 
> I think that the correct thing to do whould be to call 
>  enum command_id cmd = element_builtin_data_cmd (e);
> and use cmd instead of e->e.c->cmd.
> 
> Ok if I implement that change?

Yes please.