Re: texinfo-7.2.92 pretest available [use of strndup]

On Thu, Feb 19, 2026 at 07:05:50PM +0100, Patrice Dumas wrote:
> > At this stage, I'm actually slightly concerned about adding new include
> > directives to files and worry it could cause breakage due to the wrong
> > definitions being used, files being included in the wrong order, or whatever.
> > I don't want to do another pretest as it has already been tested enough
> > and we are hardly making any changes now, and it's a burden on interested
> > users who want to help test the pretests.
> > 
> > I notice that convert/call_conversion_perl.c does not include any system
> > include files either and yet it uses fprintf and size_t, at least.  Yet
> > there have been no reports of errors.  Evidently the correct header files
> > are being included indirectly.
> > 
> > I suggest that we can fix these files so they include the right headers
> > immediately after the release.
> 
> I already committed added include for the tta/C/convert/call_html_perl_function.c
> file but it could be reverted.  I do not think that there is much risk
> given that the includes are already similarly set in other similar files
> as I said above.

I've reverted the commit.  It was almost certainly ok but I just want to err
on the side of caution.  As I said before we can make this change after the
release.

The main source of doubt I had was whether including the file before or
after perl.h (and the other Perl include files) makes a difference.