Re: texinfo 4.7.91: Fix warnings

Stepan Kasal <[email protected]> writes:

> Hello Andreas,
>   thank you for the patch.
> Are you sure that there are no architectures where you change actually
> brings new warnings?

Any sane architecture has sizeof(void*) >= sizeof(long).  Of course, it
would be better to use intptr_t, but that is not universally available.
And build_message_buffer already uses long for the same purpose.

>>  		  syntax_error (filename, lnum,
>>                        (char *) _("NUL character (^%c) not permitted"),
>> +                      (void *) (long) c, NULL, NULL, NULL);
>
> Well, all these functions should use varargs.  The implementation of
> error() in gnulib could probably serve as template.

This is not as easy because build_message_buffer needs to support
positional parameters like "%2$d"

Andreas.

-- 
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
_______________________________________________
Texinfo home page: http://www.gnu.org/software/texinfo/
[email protected]
http://ff0.org/mailman/listinfo/texinfo-pretest