'reload sources' fails when maxpoll is decreased

Hi,
'reload sources' fails if the maxpoll value is decreased for an existing source.
Running 'reload sources' a second time seems to readd the source.

Logs and comments below.

/Thomas

-------

Configured with --sysconfdir=/tmp --disable-ipv6 --disable-readline --without-editline --without-nettle --without-nss --without-tomcrypt --disable-nts --without-gnutls --disable-phc --disable-rtc --disable-asyncdns --disable-forcednsretry

--------

# cat /tmp/chrony.conf
driftfile /var/lib/chrony/drift
makestep  0.1 -1
rtcsync
acquisitionport 123
log statistics tracking measurements
logdir /var/log/chrony
sourcedir /tmp/chrony
hwtimestamp * minpoll 4

-------

# ./chronyd -d
2023-09-11T09:07:15Z chronyd version 4.4 starting (+CMDMON +NTP +REFCLOCK -RTC +PRIVDROP -SCFILTER -SIGND -ASYNCDNS -NTS -SECHASH -IPV6 +DEBUG)
2023-09-11T09:07:15Z Enabled HW timestamping on eth0
2023-09-11T09:07:15Z Enabled HW timestamping on eth1
2023-09-11T09:07:15Z Running with root privileges
2023-09-11T09:07:15Z Frequency 1.084 +/- 0.377 ppm read from /var/lib/chrony/drift
2023-09-11T09:07:15Z Added source 172.16.1.2
2023-09-11T09:07:21Z Selected source 172.16.1.2

<maxpoll reduced, 'reload sources' called>

2023-09-11T09:09:11Z Could not add source 172.16.1.2
2023-09-11T09:09:11Z Removed source 172.16.1.2
2023-09-11T09:09:11Z Can't synchronise: no selectable sources

<'reload sources' rerun>

2023-09-11T09:11:20Z Added source 172.16.1.2
2023-09-11T09:11:26Z Selected source 172.16.1.2

-------

# pwd
/tmp
# cat chrony/chrony.sources
server 172.16.1.2 burst iburst minpoll 6 maxpoll 10 xleave

# /tmp/chronyc sources
MS Name/IP address         Stratum Poll Reach LastRx Last sample
===============================================================================
^* 172.16.1.2                    2   6    37    52  +7338ns[+6266ns] +/-   14ms

<edit, reduce maxpoll>

# cat chrony/chrony.sources
server 172.16.1.2 burst iburst minpoll 6 maxpoll 9 xleave

# /tmp/chronyc reload sources
200 OK

# /tmp/chronyc sources
MS Name/IP address         Stratum Poll Reach LastRx Last sample
===============================================================================

# /tmp/chronyc reload sources
200 OK

# /tmp/chronyc sources
MS Name/IP address         Stratum Poll Reach LastRx Last sample
===============================================================================
^* 172.16.1.2                    2   6    17     3  +6194ns[ -103us] +/-   14ms

-- 
To unsubscribe email chrony-users-request-kWFZVVI9zxvPqho9SqqRMmD2FQJk+8+b@public.gmane.org 
with "unsubscribe" in the subject.
For help email chrony-users-request-kWFZVVI9zxvPqho9SqqRMmD2FQJk+8+b@public.gmane.org 
with "help" in the subject.
Trouble?  Email [email protected]