Re: sourcedir reload ignores the maxsources option

Miroslav Lichvar <[email protected]> Mon, 2 Jun 2025 16:12:19 +0200
Newsgroups gmane.comp.time.chrony.user
Message-ID <aD2xQ1XbHozR-9OB@localhost>
On Sat, May 31, 2025 at 07:00:12PM +0200, Vincent Blut wrote:
> chrony 4.6 introduced quite a few changes to the way time sources are
> loaded from sourcedir. It seems, though, that we now have a regression¹
> as the 'maxsources' option is now ignored when reloading sources.

Thanks for forwarding the report. I can reproduce the problem and I
have a fix ready. It's not just pools, it impacts all sources loaded
from a sourcedir not specified by IP address (i.e. those that start
as "unresolved").

The patch will apply cleanly to 4.6(.1) if you would like to add it to
the downstream package. I just need to add a proper test of the
sourcedir directive with runtime changes so a bug like this doesn't
happen again (it requires some improvements in the testing framework
to be able to modify the file during test).

-- 
Miroslav Lichvar


-- 
To unsubscribe email chrony-users-request-kWFZVVI9zxvPqho9SqqRMmD2FQJk+8+b@public.gmane.org 
with "unsubscribe" in the subject.
For help email chrony-users-request-kWFZVVI9zxvPqho9SqqRMmD2FQJk+8+b@public.gmane.org 
with "help" in the subject.
Trouble?  Email [email protected]