Re: Minor source patches

Adriaan de Groot wrote:

> Two little patches: one fixes some typo's in comments,

I'll include that, thanks.

> and the
> doadddef patch adds one more install-ltlib install target, since
> ltlibs need to be installed through libtool, not /bin/install. It will
> need an action in default.aap as well. I use:
> 
>     :action installltlib default
>         @for i in var2dictlist(source):
>             destltlib=$DESTDIR/$PREFIX/$DLLDIR
>             @if i.has_key("installdir"):
>                 @destltlib += "/" + i["installdir"] + "/"
>             @destltlib = os.path.abspath(destltlib)
>             @try:
>                 @os.makedirs(destltlib)
>             @except OSError:
>                 :print $destltlib already exists

I think ":mkdir {recursive}{force} $destltlib" could have been used here.

>             @destltlib = destltlib + "/" + i["name"]
>             @destltlib = os.path.abspath(destltlib)
>             :sys $libtool --mode=install /usr/bin/install `i["name"]` $destltlib
> 
> but this seems rather hackish to me. The other install targets all use 
> install_files(), which hides the complexity in the AAP sources, not in the 
> default recipe.

Well, the other targets only need to copy files, this target has to
invoke libtool.  Thus it's logical that that this action is different.
Nevertheless, the code to figure out the destination directory and
creating the directory is identical.  We don't want to repeat that.

What we could do is add an argument to the install_files() function that
specifies the command to use for copying.  An action would probably be
best, since we have a source and a target.  Thus an "copyaction"
argument could be added, and when it's present the action will be
invoked instead of using remote_copy_move().

Do you think you can make it work that way?


I have a few other items related to libtool in my todo list.  I was
hoping (expecting) you would do these as well:

- add an uninstall action
- documentation for ":ltlib"
- user manual explanation for using ":produce" and associated commands
  (you already wrote something like this a while ago)
- docs for "installdir" attribute
- a multi-like ":ltlib" command doesn't work

-- 
hundred-and-one symptoms of being an internet addict:
189. You put your e-mail address in the upper left-hand corner of envelopes.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///          Creator of Vim - Vi IMproved -- http://www.Vim.org          \\\
\\\              Project leader for A-A-P -- http://www.A-A-P.org        ///
 \\\  Help AIDS victims, buy here: http://ICCF-Holland.org/click1.html  ///


-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0