Re: Problems with --install vim

Johan Svedberg wrote:

> I'm getting the following when trying aap --install vim with
> A-A-P recipe executive version 1.033; released 2003 Sep 25 19:04:23 GMT
> 
> Aap: Creating directory "/home/w/winkle/.aap/packages/vim"
> Aap: Entering directory `/home/w/winkle/.aap/packages/vim'
> Aap: Attempting download of "http://www.a-a-p.org/package.php?package=vim&osname=posix"
> Aap: Downloaded "http://www.a-a-p.org/package.php?package=vim&osname=posix" to "boot.aap"
> This will build Vim on Posix machines.
> Aap: Internal Error
> Aap: Traceback (most recent call last):
>    File "/home/w/winkle/pkg/aap/CVS/Exec/Process.py", line 1114, in Process
>     exec script_string in recdict, recdict
>    File "<string>", line 20, in ?
>    File "/home/w/winkle/pkg/aap/CVS/Exec/RecPython.py", line 657, in do_Debian_pkg
>     if int(c) <= 32 or int(c) >= 127:
>  ValueError: invalid literal for int(): v
> 
> Aap: Aborted
> 
> Any ideas?

This is a bug in do_Debian_pkg().  I have asked a Debian person to test
this, but apparently he didn't have time yet...

Anyway, this patch should fix the reported problem.  Let me know if
there are any other problems.

*** RecPython.py~	Thu Sep 25 19:38:51 2003
--- RecPython.py	Sun Sep 28 16:31:27 2003
***************
*** 654,660 ****
      # Safety check: don't allow non-printable and non-ASCII characters in the
      # package name, since we are feeding it to a shell.
      for c in name:
!         if int(c) <= 32 or int(c) >= 127:
              print _("Illegal character '%s' in package name '%s'") % (c, name)
              return 0
  
--- 654,660 ----
      # Safety check: don't allow non-printable and non-ASCII characters in the
      # package name, since we are feeding it to a shell.
      for c in name:
!         if ord(c) <= 32 or ord(c) >= 127:
              print _("Illegal character '%s' in package name '%s'") % (c, name)
              return 0
  

-- 
Change is inevitable, except from a vending machine.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///          Creator of Vim - Vi IMproved -- http://www.Vim.org          \\\
\\\              Project leader for A-A-P -- http://www.A-A-P.org        ///
 \\\  Help AIDS victims, buy here: http://ICCF-Holland.org/click1.html  ///


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf