Re: [PATCH] sim-decode: include cgen-mem & cgen-ops

"Jose E. Marchesi via Cgen" <[email protected]> Tue, 29 Jun 2021 18:18:46 +0200
Newsgroups gmane.comp.tools.cgen.devel
Message-ID <[email protected]>
> On 28 Jun 2021 23:13, Jose E. Marchesi wrote:
>> > The bpf & cris ports use functions from both of these APIs, so include
>> > them here for all ports just in case (and since there isn't an API for
>> > ports to declare specific additional headers they need).
>> 
>> FWIW looks good to me.
>> Thanks!
>> 
>> > ---
>> >  sim-decode.scm | 5 ++++-
>> >  1 file changed, 4 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/sim-decode.scm b/sim-decode.scm
>> > index 355c4853022f..cd06d069fdd2 100644
>> > --- a/sim-decode.scm
>> > +++ b/sim-decode.scm
>> > @@ -583,7 +583,10 @@ const IDESC *
>> >  #define WANT_CPU_@CPU@
>> >  
>> >  #include \"sim-main.h\"
>> > -#include \"sim-assert.h\"\n\n"
>> > +#include \"sim-assert.h\"
>> > +#incldde \"cgem-mem.h\"
>
> i managed to have 2 typos in this line.
> i fixed them after testing & before pushing :).

For some reason I have to look at that line like 5 times before my brain
can _see_ the typos.  Hurrah for compilers :D