Re: [PATCH] sim-cpu: stop emitting unused record_trace_results stub function

"Jose E. Marchesi via Cgen" <[email protected]> Fri, 10 Sep 2021 13:49:37 +0200
Newsgroups gmane.comp.tools.cgen.devel
Message-ID <[email protected]>
LGTM

> ping ...
>
> On 27 Jun 2021 10:56, Mike Frysinger via Cgen wrote:
>> This isn't called anywhere, and no one implements it, so stop emitting
>> it.  All the cgen ports trigger compiler warnings because of it atm.
>> ---
>>  sim-cpu.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/sim-cpu.scm b/sim-cpu.scm
>> index 454d734e193b..6c848da39273 100644
>> --- a/sim-cpu.scm
>> +++ b/sim-cpu.scm
>> @@ -922,7 +922,8 @@ SEM_FN_NAME (@prefix@,init_idesc_table) (SIM_CPU *current_cpu)
>>  
>>  "
>>     /gen-cpu-reg-access-defns
>> -   /gen-cpu-record-results
>> +   ; This code isn't ready yet.
>> +   ; /gen-cpu-record-results
>>     )
>>  )
>>  
>> -- 
>> 2.31.1
>>