Re: Improve stack smashing protector check
Vicente Olivert Riera <[email protected]>
| Newsgroups | gmane.comp.tools.sudo.devel |
|---|---|
| Message-ID | <[email protected]> |
Dear Todd C. Miller, On 10/29/2015 04:57 PM, Todd C. Miller wrote: > On Thu, 29 Oct 2015 05:41:56 -0600, "Todd C. Miller" wrote: > >> On Wed, 28 Oct 2015 13:58:21 -0000, Vicente Olivert Riera wrote: >> >>> The attached patch is an improvement for the stack smashing protector >>> check in the configure.ac file. >> >> This is a good idea but it needs to use AC_COMPILE_IFELSE instead >> of calling CC directly. I'll take a stab at this for the upcoming >> 1.8.16 release. > > I've just committed the following: > http://www.sudo.ws/repos/sudo/rev/4ade5d1249f4 I have tested your patch and it doesn't work: [snip] checking whether C compiler accepts -fstack-protector-strong... yes checking whether the linker accepts -fstack-protector-strong... yes [snip] sudoreplay.o: In function `match_expr': sudoreplay.c:(.text+0x798): undefined reference to `__stack_chk_guard' sudoreplay.c:(.text+0x9f0): undefined reference to `__stack_chk_fail' [snip] Regards, Vincent. > - todd > ____________________________________________________________ sudo-workers mailing list <[email protected]> For list information, options, or to unsubscribe, visit: http://www.sudo.ws/mailman/listinfo/sudo-workers