Re: RFC: Deleting dead/EOL grabbers from repository
Gary Buhrmaster <[email protected]> Sun, 18 Feb 2018 18:42:12 +0000
| Newsgroups | gmane.comp.tv.xmltv.devel |
|---|---|
| Message-ID | <CAMfXtQyt1C8V5x2vAX+ZEm3LhkCFzTPKwU1k1emrFt4aBL_gkw@mail.gmail.com> |
On Sat, Feb 17, 2018 at 3:35 AM, Nick Morrott <[email protected]> wrote: > We are now using git, a distributed version control system where > everyone has a complete copy of the project's history, > > Prompted by some recent PRs removing a couple of dead grabbers > (deleting the grabber files in addition to commenting them out in > Makefile.PL) I am seeking feedback on whether we should do the same > for all other dead/EOL grabbers? > > Significantly, it would clean up not only grab/, but also Makefile.PL > itself, aiding future maintenance and removing accumulated cruft. > > Before I go ahead and do this, I wanted to check for any objections/comments. Git remembers forever. However, not all people do (and newcomers may join the project), and while I am comfortable with git (and its capabilities), not all people are. There is a possible middle ground, where there is a new directory called (say) archive which could be used just for old grabbers moved into it in the case easy browsing of the legacy source might be valuable for some to review (perhaps as a starting point for a new implementation of a abandoned grabber, or simply for the "how did that work" question). So, if voting counts (and it probably should not be), I vote in favor for delete and be done with it(*). I would not be opposed to an archive directory. I would be opposed to leaving grabbers that do not work (and have no maintainer working on fixing it) in the main repo and built for distribution. (*) I would request one file delete per commit, but that is a nit. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot