Re: How do I do a code review?

Larry McVoy <[email protected]>
Newsgroups gmane.comp.version-control.bitkeeper.user
Message-ID <[email protected]>
On Mon, Sep 13, 2004 at 03:27:05PM -0500, Timur Tabi wrote:
> We have situations where individuals check in a bunch of changes, and 
> then want their code to be reviewed.  Therefore, the review is of the 
> recently checked-in code and whatever exists in the parent.  The idea is 
> that if the code review passes, then the developer will push his changes 
> into the parent.

In general the easiest way to do this is to have the developer create a
changeset and send out mail as to the location.  Here at BitMover, we
put things we want reviewed in a public "queue" which is just a big 
collection of repositories waiting to be integrated.

The review process is to clone the repo locally and then do a "bk csettool -r+"
which gives you a graphical view of the most recent changeset.

If there were more than one change you can do this:

	bk csettool -r`bk changes -L -nd:I:,`

and that will run csettool on the local only changes.
-- 
---
Larry McVoy                lm at bitmover.com           http://www.bitkeeper.com
_______________________________________________
Bitkeeper-users mailing list
[email protected]
http://bitmover.com/mailman/listinfo/bitkeeper-users
To unsubscribe from this list, go to the above URL, follow instruction at the bottom of the web page.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.